Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NEUTRONRCG4AIO config file #12535

Merged
merged 1 commit into from Mar 23, 2023
Merged

Fix NEUTRONRCG4AIO config file #12535

merged 1 commit into from Mar 23, 2023

Conversation

ctzsnooze
Copy link
Member

@ctzsnooze ctzsnooze commented Mar 17, 2023 •
edited

Supports the LSM6DSO acc/gyro and DPS310 Baro on the NEUTRONRCG4AIO board.

Reviewers please check that the changes 'make sense'. There was a spelling mistake in settings.c, and LSM6DSO wasn't included in gyro_init.c.

I have only one board of this type, and it is now working well with 4.5 Zulu.

@ctzsnooze ctzsnooze changed the title Fix NeutronRcG4Aio config file Fix NEUTRONRCG4AIO config file Mar 17, 2023
@ctzsnooze ctzsnooze self-assigned this Mar 17, 2023
@ctzsnooze ctzsnooze requested review from blckmn and haslinghuis and removed request for blckmn March 17, 2023 07:03
@github-actions

This comment has been minimized.

Sign in to view
@ctzsnooze ctzsnooze force-pushed the NeutronRcG4AIO-Config branch 2 times, most recently from d392c87 to 35e1bff Compare March 17, 2023 07:09
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Mar 17, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 17, 2023
nerdCopter
nerdCopter approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code-reading looks good, but i cannot actually test it.

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@ctzsnooze ctzsnooze merged commit e7cb9af into betaflight:master Mar 23, 2023
19 checks passed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@ctzsnooze @davidbitton
Fix NEUTRONRCG4AIO config file (betaflight#12535)
923a0c8 
LSM6DSO in NEUTRONRCG4AIO, fix typos
@ctzsnooze ctzsnooze deleted the NeutronRcG4AIO-Config branch April 3, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@ctzsnooze ctzsnooze

Labels
Bugfix Ready to Merge RN: TARGET UPDATE Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ctzsnooze @blckmn @haslinghuis @klutvott123 @nerdCopter