New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONFIG: Fix TODO MAG & I2C #12545

Merged

blckmn merged 1 commit into betaflight:master from haslinghuis:fix-mag

Apr 9, 2023

+28 −260

Member

haslinghuis commented Mar 19, 2023 •

edited

Fixes: MAG was always defaulting to SPI. Changed USE_SPI to USE_SPI_MAG.

Fixes:

MAG_SPI_DEVICE x => MAG_SPI_INSTANCE SPIx
MAG_I2C_ADDRESS
I2C1_PULLUP
I2C2_PULLUP
I2C3_PULLUP
I2C4_PULLUP

Cloud build would set these settings by default:

MAG_BUSTYPE I2C
MAG_BUSTYPE NONE
MAG_BUSTYPE SLAVE
MAG_HARDWARE AUTO
MAG_HARDWARE NONE

haslinghuis added Cleanup RN: TARGET UPDATE Bugfix labels

haslinghuis added this to the 4.5 milestone

haslinghuis self-assigned this

This comment has been minimized.

Sign in to view

Member

blckmn commented Mar 19, 2023 •

edited

AUTOMERGE: (FAIL)

github identifies PR as mergeable -> FAIL
assigned to a milestone -> PASS
cooling off period lapsed -> PASS
commit count less or equal to three -> PASS
Don't merge label NOT found -> PASS
at least one RN: label found -> PASS
Tested label found -> FAIL
assigned to an approver -> PASS
approver count at least three -> FAIL

ctzsnooze approved these changes

View reviewed changes

haslinghuis force-pushed the fix-mag branch from 3abf668 to 25582f6 Compare

March 21, 2023 03:24

This comment has been minimized.

Sign in to view

haslinghuis requested review from blckmn, KarateBrot and klutvott123

March 22, 2023 21:42

blckmn requested changes

View reviewed changes

src/config/ALIENFLIGHTNGF7/config.h Outdated Show resolved Hide resolved

haslinghuis force-pushed the fix-mag branch from 25582f6 to b66af65 Compare

March 22, 2023 21:47

This comment has been minimized.

Sign in to view

haslinghuis requested a review from blckmn

March 22, 2023 21:50

haslinghuis force-pushed the fix-mag branch from b66af65 to 9013312 Compare

March 28, 2023 20:47

This comment has been minimized.

Sign in to view

KarateBrot approved these changes

View reviewed changes

haslinghuis force-pushed the fix-mag branch 2 times, most recently from 5852a20 to aebe7fd Compare

April 2, 2023 20:01

This comment has been minimized.

Sign in to view

haslinghuis force-pushed the fix-mag branch from aebe7fd to 833692a Compare

April 4, 2023 20:11

This comment has been minimized.

Sign in to view


          Fix mag

0edd5ca

haslinghuis force-pushed the fix-mag branch from 833692a to 0edd5ca Compare

April 4, 2023 20:42

github-actions bot commented Apr 4, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

Member Author

haslinghuis commented Apr 4, 2023

Rebased and added I2C Pullup's

fabriciopolonio mentioned this pull request

Magnetometer not working with new Walksnail WS-M181 GPS #12640

Closed

blckmn approved these changes

View reviewed changes

blckmn merged commit af97415 into betaflight:master

19 checks passed

haslinghuis deleted the fix-mag branch

April 9, 2023 22:40

davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request


          CONFIG: Fix TODO MAG & I2C (betaflight#12545)

2820f3c

Fix mag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment