Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONFIG: define W25Q128FV for OMNIBUSF4 #12547

Merged
merged 1 commit into from Mar 20, 2023
Merged

CONFIG: define W25Q128FV for OMNIBUSF4 #12547

merged 1 commit into from Mar 20, 2023

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Mar 19, 2023 •
edited

@github-actions

This comment has been minimized.

Sign in to view
haslinghuis
haslinghuis requested changes Mar 19, 2023
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add USE_FLASH

src/config/OMNIBUSF4/config.h Show resolved Hide resolved
@haslinghuis haslinghuis added this to the 4.5 milestone Mar 19, 2023
@nerdCopter nerdCopter force-pushed the 20230319_define_W25Q128FV_for_OMNIBUSF4 branch from 4a3a346 to e0fb1fb Compare March 19, 2023 19:59
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Mar 19, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 02ddc74 into betaflight:master Mar 20, 2023
18 checks passed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@nerdCopter @davidbitton
CONFIG: define W25Q128FV for OMNIBUSF4 (betaflight#12547)
6a2a0b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

Assignees

@nerdCopter nerdCopter

Labels
RN: TARGET UPDATE
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nerdCopter @blckmn @haslinghuis @klutvott123