Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup + led overlay expansion #12554

Merged
merged 2 commits into from Apr 6, 2023
Merged

Cleanup + led overlay expansion #12554

merged 2 commits into from Apr 6, 2023

Conversation

ASDosjani
Copy link
Contributor

@ASDosjani ASDosjani commented Mar 21, 2023 •
edited

Deleted an unused parameter from ledConfig_t + cleanup.
Configurator changes: betaflight/betaflight-configurator#3390

please test

@github-actions

This comment has been minimized.

Sign in to view
@ASDosjani ASDosjani mentioned this pull request Mar 21, 2023
Merged
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Mar 21, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 22, 2023
@ASDosjani ASDosjani marked this pull request as draft March 23, 2023 20:44
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@ASDosjani ASDosjani marked this pull request as ready for review March 26, 2023 14:08
@sugaarK sugaarK merged commit e195bf7 into betaflight:master Apr 6, 2023
19 checks passed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@ASDosjani @davidbitton
Cleanup + led overlay expansion (betaflight#12554)
3d69605 
* Cleanup + led overlay expansion

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@sugaarK sugaarK sugaarK approved these changes

Assignees

@ASDosjani ASDosjani

Labels
Cleanup RN: IMPROVEMENT Testing Required
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ASDosjani @blckmn @haslinghuis @ctzsnooze @sugaarK