Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing rx_spi_bus config to SX1280 targets #12567

Merged
merged 1 commit into from Mar 28, 2023

Conversation

ot0tot
Copy link
Contributor

@ot0tot ot0tot commented Mar 25, 2023

These SX1280 targets did not have rx_spi_bus and rx_spi_led_inversion set, so the SPI receiver was not working after flashing (rx_spi_bus was set to 0).

See: betaflight/unified-targets#962

These SX1280 targets did not have rx_spi_bus and rx_spi_led_inversion set, so the SPI receiver was not working after flashing (rx_spi_bus was set to 0).

See: betaflight/unified-targets#962
@blckmn
Copy link
Member

blckmn commented Mar 25, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn merged commit 8bfc58e into betaflight:master Mar 28, 2023
18 checks passed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

3 participants