Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable AIRBOTF435 MAX7456 #12584

Merged
merged 1 commit into from Mar 27, 2023
Merged

Enable AIRBOTF435 MAX7456 #12584

merged 1 commit into from Mar 27, 2023

Conversation

SteveCEvans
Copy link
Member

Add support for AIRBOTF435 MAX7456 OSD.

@SteveCEvans SteveCEvans self-assigned this Mar 27, 2023
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 27, 2023
haslinghuis
haslinghuis approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:

Current config is based on revision 1.0
MAX7456_SPI_INSTANCE has changed from 3 to 1

@SteveCEvans
Copy link
Member Author

I'm using V1.1. I think we'll need a AIRBOTF435V2 target.

@blckmn
Copy link
Member

blckmn commented Mar 27, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added Tested and removed Tested labels Mar 27, 2023
@haslinghuis haslinghuis merged commit caa497e into betaflight:master Mar 27, 2023
18 checks passed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@SteveCEvans @davidbitton
Enable AIRBOTF435 MAX7456 (betaflight#12584)
cd0f976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

@klutvott123 klutvott123 Awaiting requested review from klutvott123

Assignees

@SteveCEvans SteveCEvans

Labels
RN: TARGET UPDATE
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SteveCEvans @blckmn @haslinghuis @ctzsnooze