Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NEUTRONRCF7AIO Target Defines #12588

Merged

Conversation

benjamind2
Copy link
Contributor

  • Add gyro defines (Gyro 1: BMI270, Gyro 2: ICM-20689)
  • Add flash defines (W25N01G)
  • Add OSD defines (MAX7456)
  • Remove MAG orientation defines (Build specific)
  • Remove default yaw offset (Gyro is not at 45 deg)

Tested both gyros.


Status from working 4.4.0 core

MCU F745 Clock=216MHz, Vref=3.30V, Core temp=42degC
Stack size: 2048, Stack address: 0x20010000
Configuration: CONFIGURED, size: 4192, max available: 32768
Devices detected: SPI:2, I2C:0
Gyros detected: gyro 1, gyro 2 locked dma
GYRO=BMI270, ACC=BMI270
OSD: MAX7456 (30 x 13)
BUILD KEY: 2450ef5c51a6e1c4e397015611fa704c (4.4.0)
System Uptime: 10 seconds, Current Time: 2023-03-28T15:34:12.140+00:00
CPU:20%, cycle time: 312, GYRO rate: 3205, RX rate: 15, System rate: 9
Voltage: 439 * 0.01V (0S battery - NOT PRESENT)
I2C Errors: 22
SD card: Not configured
FLASH: JEDEC ID=0x00efaa21 128M
Arming disable flags: RXLOSS CLI MSP

Status after my changes:

MCU F745 Clock=216MHz, Vref=3.30V, Core temp=42degC
Stack size: 2048, Stack address: 0x20010000
Configuration: CONFIGURED, size: 4192, max available: 32768
Devices detected: SPI:2, I2C:0
Gyros detected: gyro 1, gyro 2 locked dma
GYRO=BMI270, ACC=BMI270
OSD: MAX7456 (30 x 13)
BUILD KEY: 2450ef5c51a6e1c4e397015611fa704c (4.4.0)
System Uptime: 10 seconds, Current Time: 2023-03-28T15:34:12.140+00:00
CPU:20%, cycle time: 312, GYRO rate: 3205, RX rate: 15, System rate: 9
Voltage: 439 * 0.01V (0S battery - NOT PRESENT)
I2C Errors: 22
SD card: Not configured
FLASH: JEDEC ID=0x00efaa21 128M
Arming disable flags: RXLOSS CLI MSP

NOTE: i2c errors are because my board does not have the baro populated. I'll test the baro once it gets here from AliExpress.

 - Add gyro defines (Gyro 1: BMI270, Gyro 2: ICM-20689)
 - Add flash defines (W25N01G)
 - Add OSD defines (MAX7456)
 - Remove MAG orientation defines (Build specific)
 - Remove default yaw offset (Gyro is not at 45 deg)
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@benjamind2
Copy link
Contributor Author

Notes:

  • Tested both gyros
  • Tested flash
  • Can't test baro b/c mine isn't populated
  • Verified OSD shows up correctly, but can't test b/c I don't have analog VTX equipment
  • Mag orientation removed because mag orientation is a property of a quadcopter layout, not the target.

Diff of Status is between 4.4.0 core (most recent working) and my build (off master).
Can't get any more recent comparisons because the missing gyro defines prevented 4.4.1 and 4.5 from compiling.

@blckmn
Copy link
Member

blckmn commented Mar 28, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@blckmn blckmn merged commit 53dbe1a into betaflight:master Mar 29, 2023
18 checks passed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
- Add gyro defines (Gyro 1: BMI270, Gyro 2: ICM-20689)
 - Add flash defines (W25N01G)
 - Add OSD defines (MAX7456)
 - Remove MAG orientation defines (Build specific)
 - Remove default yaw offset (Gyro is not at 45 deg)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

3 participants