Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obtain HSE_VALUE from config.h where provided. #12632

Merged
merged 1 commit into from Apr 13, 2023
Merged

Obtain HSE_VALUE from config.h where provided. #12632

merged 1 commit into from Apr 13, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Apr 6, 2023

Attempt to set the HSE_VALUE in the Makefile by parsing the config.h for SYSTEM_HSE_MHZ.

Noting this does not adjust the behaviour of being able to adjust it via the cli afterwards.

@blckmn blckmn self-assigned this Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn mentioned this pull request Apr 6, 2023
Merged
@blckmn blckmn requested a review from haslinghuis April 6, 2023 23:55
@haslinghuis haslinghuis added this to the 4.5 milestone Apr 7, 2023
haslinghuis added a commit to haslinghuis/betaflight that referenced this pull request Apr 7, 2023
@haslinghuis
Changes after betaflight#12632
eca3e1a
haslinghuis added a commit to haslinghuis/betaflight that referenced this pull request Apr 7, 2023
@haslinghuis
Changes after betaflight#12632
815820e
haslinghuis added a commit to haslinghuis/betaflight that referenced this pull request Apr 7, 2023
@haslinghuis
Changes after betaflight#12632
e93e3e6
haslinghuis added a commit to haslinghuis/betaflight that referenced this pull request Apr 7, 2023
@haslinghuis
Changes after betaflight#12632
d4d7e17
haslinghuis added a commit to haslinghuis/betaflight that referenced this pull request Apr 7, 2023
@haslinghuis
Changes after betaflight#12632
cc7a1ee
@blckmn
Copy link
Member Author

blckmn commented Apr 7, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

haslinghuis added a commit to haslinghuis/betaflight that referenced this pull request Apr 7, 2023
@haslinghuis
Changes after betaflight#12632
1db1eb2
haslinghuis added a commit to haslinghuis/betaflight that referenced this pull request Apr 7, 2023
@haslinghuis
Changes after betaflight#12632
8e5d1c7
haslinghuis added a commit to haslinghuis/betaflight that referenced this pull request Apr 7, 2023
@haslinghuis
Changes after betaflight#12632
59b67c6
haslinghuis added a commit to haslinghuis/betaflight that referenced this pull request Apr 7, 2023
@haslinghuis
Changes after betaflight#12632
a1477c6
blckmn pushed a commit that referenced this pull request Apr 10, 2023
@haslinghuis
Fix Mercury G4 and fix TODO for PID_PROCESS_DENOM for all targets (#1…
567d3dd 
…2611)

* Fix Mercury G4

* Changes after #12632

* Fix TODO for PID_PROCESS_DENOM
@blckmn blckmn merged commit ba01a6a into betaflight:master Apr 13, 2023
18 checks passed
@blckmn blckmn deleted the hse_value branch April 13, 2023 03:33
@haslinghuis haslinghuis mentioned this pull request Apr 13, 2023
Closed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Fix Mercury G4 and fix TODO for PID_PROCESS_DENOM for all targets (be…
3e60fbf 
…taflight#12611)

* Fix Mercury G4

* Changes after betaflight#12632

* Fix TODO for PID_PROCESS_DENOM
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@blckmn @davidbitton
Obtain HSE_VALUE from config.h where provided. (betaflight#12632)
0fa9923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@klutvott123 klutvott123 Awaiting requested review from klutvott123

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees

@blckmn blckmn

Labels
Ready to Merge RN: IMPROVEMENT Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blckmn @haslinghuis @ctzsnooze @KarateBrot