Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PG initialization of DMA defaults for TIMUP configuration #12633

Merged
merged 3 commits into from Apr 10, 2023
Merged

Fix PG initialization of DMA defaults for TIMUP configuration #12633

merged 3 commits into from Apr 10, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Apr 7, 2023

With the removal of timerHardware configuration, the TIMUP dma was not being defaulted in the PG initialisation.

@blckmn blckmn self-assigned this Apr 7, 2023
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added this to the 4.5 milestone Apr 7, 2023
@theojalba
Copy link
Contributor

theojalba commented Apr 7, 2023 •
edited

Are some TIMUPs above 8 also valid?

For H7 TIMUPs 15,16 and 17?
H7 TIMUP_TIMERS

For G4 TIMUPs 15,16,17 and 20?
G4 TIMUP_TIMERS

For AT32 TIMUPs 9,10,11,12,13,14 and 20?
AT32 TIMUP_TIMERS

I built this branch for the H7NANO and confirmed the code works. When I go to CLI and say dma it now actually shows the TIMUPS. Nice job! 🎉

@blckmn
Copy link
Member Author

blckmn commented Apr 7, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@haslinghuis haslinghuis merged commit a831878 into betaflight:master Apr 10, 2023
19 checks passed
@blckmn blckmn deleted the timup_config branch June 7, 2023 03:23
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@blckmn @davidbitton
Fix PG initialization of DMA defaults for TIMUP configuration (betafl…
832f1be 
…ight#12633)

* Adding PG config defaults for TIMUP configuration

* Corrected index

* Adding in the additional TIMUP as commented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@sugaarK sugaarK sugaarK approved these changes

@SteveCEvans SteveCEvans Awaiting requested review from SteveCEvans

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

@klutvott123 klutvott123 Awaiting requested review from klutvott123

Assignees

@blckmn blckmn

Labels
Bugfix Ready to Merge RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@blckmn @theojalba @haslinghuis @nerdCopter @sugaarK