Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONFIG: Fix TMotor F7 BMP280 baro #12639

Merged
merged 1 commit into from Apr 9, 2023
Merged

CONFIG: Fix TMotor F7 BMP280 baro #12639

merged 1 commit into from Apr 9, 2023

Conversation

dawr68
Copy link
Contributor

@dawr68 dawr68 commented Apr 8, 2023

Fixes define that caused BMP280 barometer not working over SPI on T-Motor F7 flight controller.

Tested on hardware.

@blckmn
Copy link
Member

blckmn commented Apr 8, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> PASS

SteveCEvans
SteveCEvans approved these changes Apr 8, 2023
View reviewed changes
Copy link
Member

@SteveCEvans SteveCEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a TMOTORF7HD with BMP280 added.

@haslinghuis haslinghuis added this to the 4.5 milestone Apr 8, 2023
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@haslinghuis haslinghuis merged commit 99ae6d8 into betaflight:master Apr 9, 2023
18 checks passed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@dawr68 @davidbitton
CONFIG: Fix TMotor F7 BMP280 baro (betaflight#12639)
086641b 
Fix BMP280 define
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@SteveCEvans SteveCEvans SteveCEvans approved these changes

Assignees

@dawr68 dawr68

Labels
RN: TARGET UPDATE
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dawr68 @blckmn @McGiverGim @haslinghuis @SteveCEvans