New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flash M25P16 ID with QUADSPI #12670
Conversation
Do you want to test this code? Here you have an automated build: |
AUTOMERGE: (FAIL)
|
The code in The issue stemmed from two PR's making changes to the same code, one or the other of the PR's should have had a failing build at the time they were merged. See #11825 and #12103. @haslinghuis @blckmn This situation can be avoided if there is a pre-merge check that builds all the targets and that at least one target exists for the QUADSPI/M25P16 combination. The development Nucleo board targets used to cover many of the combinations prior to their removal. Currently the code-base cannot be relied on to even compile. |
@blckmn Would like to restore the NUCLEO F446RE target as I ordered this board. |
@haslinghuis lets restore that target, and add it to the checks. |
Fixes the M25P16 flash identification when used with QUADSPI