Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONFIG] Add NUCLEOF446 Development Board #12678

Merged
merged 1 commit into from Jun 14, 2023
Merged

[CONFIG] Add NUCLEOF446 Development Board #12678

merged 1 commit into from Jun 14, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Apr 15, 2023 •
edited

Based on the legacy target.

Refer to UM1724

Config.h moved to config repo.

@haslinghuis haslinghuis added this to the 4.5 milestone Apr 15, 2023
@haslinghuis haslinghuis self-assigned this Apr 15, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the add-nucleof446re branch 2 times, most recently from 6a533d2 to d0d933f Compare April 15, 2023 20:09
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Apr 15, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis changed the title Add NUCLEOF446 Development Board CONFIG: Add NUCLEOF446 Development Board Apr 16, 2023
ctzsnooze
ctzsnooze approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@ctzsnooze ctzsnooze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a board to test, approving on the basis that it looks good - please don't merge until we get confirmation that it works from a user.

@haslinghuis haslinghuis changed the base branch from master to master-config April 26, 2023 22:22
@haslinghuis haslinghuis changed the title CONFIG: Add NUCLEOF446 Development Board [CONFIG] Add NUCLEOF446 Development Board Apr 26, 2023
@haslinghuis haslinghuis changed the base branch from master-config to master April 29, 2023 00:19
@haslinghuis haslinghuis marked this pull request as draft May 10, 2023 15:09
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Jun 10, 2023

@haslinghuis can we please finalise this one?

@haslinghuis haslinghuis force-pushed the add-nucleof446re branch 2 times, most recently from 4fa12a0 to b0077e0 Compare June 10, 2023 16:59
@haslinghuis haslinghuis marked this pull request as ready for review June 10, 2023 17:08
@haslinghuis haslinghuis force-pushed the add-nucleof446re branch 3 times, most recently from 04f8897 to cb090e5 Compare June 10, 2023 21:51
@haslinghuis haslinghuis force-pushed the add-nucleof446re branch 2 times, most recently from 92ec385 to 96a470b Compare June 11, 2023 00:28
@blckmn blckmn merged commit eb4d95e into betaflight:master Jun 14, 2023
20 checks passed
@haslinghuis haslinghuis deleted the add-nucleof446re branch June 14, 2023 07:45
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
[CONFIG] Add NUCLEOF446 Development Board (betaflight#12678)
6d5ab30 
Add NUCLEOF446 Development Board
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: NEW TARGET Testing Required
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haslinghuis @blckmn @ctzsnooze