Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bidirectional dshot on F7 #12796

Merged
merged 1 commit into from May 12, 2023
Merged

Fix bidirectional dshot on F7 #12796

merged 1 commit into from May 12, 2023

Conversation

haslinghuis
Copy link
Member

Fixes: #12794

@haslinghuis haslinghuis added this to the 4.5 milestone May 11, 2023
@haslinghuis haslinghuis self-assigned this May 11, 2023
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented May 11, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@ZzyzxTek
Copy link
Contributor

I reported the same issue on discord in #support-forum.
I flashed this PR on the TALONF7V2 that was locking up with zulu.
No lockup. Bidir dshot working, motors spin. Yay!

@haslinghuis haslinghuis merged commit 223c2b3 into betaflight:master May 12, 2023
18 checks passed
@haslinghuis haslinghuis deleted the fix-bidir-dshot branch May 12, 2023 16:56
AkankshaJjw pushed a commit to AkankshaJjw/betaflight that referenced this pull request May 29, 2023
@haslinghuis @AkankshaJjw
Fix bidirectional dshot on F7 (betaflight#12796)
e9b28e4
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Fix bidirectional dshot on F7 (betaflight#12796)
bbfe244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@ledvinap ledvinap Awaiting requested review from ledvinap

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: BUGFIX Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Hardware vault after lastest master
6 participants
@haslinghuis @blckmn @ZzyzxTek @McGiverGim @ctzsnooze @KarateBrot