PoC: OSD Menu - VTX driver separation #1284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for SmartAudio Support with single wire connection and without external pull-up. Tested with F3 only. F1 and F4 has untested mods, and Softserial haven’t been touched.
|
Great！ |
|
Rebase please |
mikeller
pushed a commit
to mikeller/betaflight
that referenced
this pull request
Mar 27, 2017
…ugal-comp IMU GPS/Gyro/Acc fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for discussion.
I did some experiment on OSD Menu - VTX driver separation. The idea is to let a VTX driver side provide OSD menu data structure for controls that the driver wishes to provide, and OSD code can drive the menu system without knowing semantics associated with the data structure.
It looks like the current (development) OSD code tries to preserve the API provided by each existing VTX drivers, but I could violate this policy :) The existing drivers could be wrapped with 'shim' codes if we are going further in this direction.
Ideally, OSD (and other display devices including I2C OLED and external OSD), configuration menu, configuration storage system should all be separated. Relevant discussions and PRs are:
(Am I missing something?)