Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong test for BOXMSPOVERRIDE channel #12857

Merged
merged 1 commit into from Jun 10, 2023

Conversation

ledvinap
Copy link
Contributor

@ledvinap ledvinap commented Jun 2, 2023

msp_override_channels_mask bits are indexed by raw channels, but auxChannelIndex (starting from NON_AUX_CHANNEL_COUNT) was used for test

`msp_override_channels_mask` bits are indexed by raw channels, but
auxChannelIndex (starting from NON_AUX_CHANNEL_COUNT) was used for test
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #12857 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@ledvinap
Copy link
Contributor Author

ledvinap commented Jun 2, 2023

@cvetaevvitaliy : Can you please test it?

@blckmn
Copy link
Member

blckmn commented Jun 2, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@cvetaevvitaliy
Copy link
Contributor

@cvetaevvitaliy : Can you please test it?

Hi!
Yes, I can test this fix tomorrow

@blckmn blckmn merged commit 16776dc into betaflight:master Jun 10, 2023
19 checks passed
@Automate5462
Copy link

I tried to achieve the same, but it does not work:
When msp_override_channels_mask is set to zero in betaflight cli, then the msp override mode disappears.
And when it is set to e.g. =1, then the msp override mode can be set, and assigned to e.g. AUX2.
But once the AUX2 triggers this mode, it is not possible to exit from this mode, as the AUX channels are not responding anymore to the transmitter.
Does anybody know, what needs to be done, so that the AUX-channels are not overwritten by the msp, but always taken from the transmitter?
(So that the transmitter can always start and stop the mode, when the msp overwrites the pitch, roll, yaw and throttle?)

davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
`msp_override_channels_mask` bits are indexed by raw channels, but
auxChannelIndex (starting from NON_AUX_CHANNEL_COUNT) was used for test

Co-authored-by: Petr Ledvina <ledvinap@hp124.ekotip.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

5 participants