Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call updateInit() before writing motor command data #12866

Merged
merged 1 commit into from Jun 21, 2023
Merged

Call updateInit() before writing motor command data #12866

merged 1 commit into from Jun 21, 2023

Conversation

SteveCEvans
Copy link
Member

Cherry pick of #12865 fixing #12860

@SteveCEvans SteveCEvans added this to the 4.4.2 milestone Jun 3, 2023
@SteveCEvans SteveCEvans self-assigned this Jun 3, 2023
@haslinghuis haslinghuis linked an issue Jun 3, 2023 that may be closed by this pull request
4.4.2 Dshot motor direction commands not working after #12709 #12860
Closed
ctzsnooze
ctzsnooze previously approved these changes Jun 4, 2023
View reviewed changes
@haslinghuis haslinghuis modified the milestones: 4.4.2, 4.4.3 Jun 4, 2023
This was referenced Jun 7, 2023
Closed
Closed
@haslinghuis
Copy link
Member

@SteveCEvans please update the cherry-pick :)

blckmn
blckmn reviewed Jun 14, 2023
View reviewed changes
src/main/drivers/dshot_command.c Outdated
@@ -182,6 +182,7 @@ void dshotCommandWrite(uint8_t index, uint8_t motorCount, uint8_t command, dshot

uint8_t repeats = 1;
timeUs_t delayAfterCommandUs = DSHOT_COMMAND_DELAY_US;
motorVTable_t vTable = motorGetVTable();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to:

Suggested change
motorVTable_t vTable = motorGetVTable();
motorVTable_t *vTable = motorGetVTable();

Along with the other pointer changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to pull in the latest changes from the original PR

nerdCopter
nerdCopter previously approved these changes Jun 14, 2023
View reviewed changes
@nerdCopter nerdCopter self-requested a review June 14, 2023 15:31
@nerdCopter
Copy link
Member

nerdCopter commented Jun 14, 2023 •
edited

i dismissed my approval.
i noticed #12865 had 3 files changed.

KarateBrot
KarateBrot requested changes Jun 14, 2023
View reviewed changes
Copy link
Member

@KarateBrot KarateBrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ready for approval yet

@limonspb
Copy link
Member

Not ready for approval yet

what about this one, it was merged already:
#12865

@KarateBrot
Copy link
Member

what about this one, it was merged already: #12865

That one was ready for approval. This PR needs to be updated first.

@haslinghuis haslinghuis dismissed stale reviews from nerdCopter and ctzsnooze via 87b5e95 June 18, 2023 23:42
@haslinghuis haslinghuis requested review from blckmn, ctzsnooze and KarateBrot and removed request for nerdCopter June 18, 2023 23:44
@haslinghuis haslinghuis requested review from nerdCopter and ctzsnooze and removed request for ctzsnooze June 18, 2023 23:44
@haslinghuis
Copy link
Member

haslinghuis commented Jun 18, 2023 •
edited

Sorry for the ping. Updated the PR - but this one seems to complain 😕 as it's now an exact copy

image

KarateBrot
KarateBrot requested changes Jun 19, 2023
View reviewed changes
Copy link
Member

@KarateBrot KarateBrot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vTable is a pointer

src/main/drivers/dshot_command.c Outdated Show resolved Hide resolved
src/main/drivers/dshot_command.c Outdated Show resolved Hide resolved
src/main/drivers/dshot_command.c Outdated Show resolved Hide resolved
src/main/drivers/dshot_command.c Outdated Show resolved Hide resolved
src/main/drivers/dshot_command.c Outdated Show resolved Hide resolved
@haslinghuis haslinghuis force-pushed the 4.4-maintenance-12865 branch 2 times, most recently from 9b7d166 to ef67423 Compare June 19, 2023 00:47
@limonspb
Copy link
Member

limonspb commented Jun 20, 2023 •
edited

tested PR this on H7 + 4.4-maintenance, reverses the motors normally, spins them ok with both bidirectional ON and OFF.

@limonspb
Copy link
Member

tested new PR state. All seems to be still working :)

@haslinghuis haslinghuis merged commit a35fa26 into betaflight:4.4-maintenance Jun 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@ledvinap ledvinap Awaiting requested review from ledvinap

@limonspb limonspb Awaiting requested review from limonspb

@klutvott123 klutvott123 Awaiting requested review from klutvott123

@blckmn blckmn Awaiting requested review from blckmn

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

@nerdCopter nerdCopter Awaiting requested review from nerdCopter

Assignees

@SteveCEvans SteveCEvans

Labels
Added by Cherry-pick RN: BUGFIX
Projects
None yet
Milestone
4.4.3
Development

Successfully merging this pull request may close these issues.

4.4.2 Dshot motor direction commands not working after #12709
7 participants
@SteveCEvans @haslinghuis @nerdCopter @limonspb @KarateBrot @blckmn @ctzsnooze