Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables retrieval of the RELEASE_NAME using MSP2 #12878

Merged
merged 1 commit into from Jun 11, 2023
Merged

Enables retrieval of the RELEASE_NAME using MSP2 #12878

merged 1 commit into from Jun 11, 2023

Conversation

haslinghuis
Copy link
Member

In addition to #12264 this enables retrieval of build options from a previous version.

See also: #12876

@haslinghuis haslinghuis added this to the 4.5 milestone Jun 9, 2023
@haslinghuis haslinghuis self-assigned this Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #12878 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

ledvinap
ledvinap approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@ledvinap ledvinap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, after fixing pointer dereference

src/main/cli/cli.c Outdated Show resolved Hide resolved
src/main/cli/cli.c Outdated Show resolved Hide resolved
@blckmn
Copy link
Member

blckmn commented Jun 9, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis requested a review from blckmn June 9, 2023 21:21
@haslinghuis haslinghuis merged commit 7d1007e into betaflight:master Jun 11, 2023
18 checks passed
@haslinghuis haslinghuis deleted the retrieve-releasename branch June 11, 2023 00:28
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Enables retrieval of the RELEASE_NAME using MSP2 (betaflight#12878)
b6ade43 
Retrieve releasename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ledvinap ledvinap ledvinap approved these changes

@blckmn blckmn blckmn approved these changes

@sugaarK sugaarK sugaarK approved these changes

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haslinghuis @blckmn @ledvinap @sugaarK