Rename make folder to get rid of build error.

[avida]

When trying to build firmware with current directory in PATH environment it scans for make command and generates "Permission denied" error in case if current directory in PATH precedes /usr/bin/ directory.In my case it was caused by incorrect pyenv init script.

Rename make folder to avoid errors like this.

[github-actions]

Do you want to test this code? You can flash it directly from Betaflight Configurator:

• Simply put #12880 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> PASS
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> FAIL
• Tested label found -> FAIL
• assigned to an approver -> FAIL
• approver count at least three -> PASS

[blckmn]

Could you please rename this directory to mk as all the others use shortened names. e.g. src, lib etc

[avida]

Could you please rename this directory to mk as all the others use shortened names. e.g. src, lib etc

Done.

[ledvinap]

@avida what system are you using?

[avida]

@avida what system are you using?

Linux Mint, pyenv 2.3.19

[ledvinap]

@avida : Well, it seems to be bug in GNU make ..

[ledvinap]

Bug is already fixed in coreutil (and make). coreutils/gnulib@6e6abd0

[ledvinap]

The MAKE_SCRIPT_DIR is definitely good idea. But rename make -> mk may not be necessary. make bug is already fixed (but it will take some time; bug was fixed in 2020). Maybe just document this behavior and assume users are using sane build environment.

Already fixed?

[blckmn]

The MAKE_SCRIPT_DIR is definitely good idea. But rename make -> mk may not be necessary. make bug is already fixed (but it will take some time; bug was fixed in 2020). Maybe just document this behavior and assume users are using sane build environment.

I am ok with the rename. it shouldn't cause any issues (aside from rebases required if there are PRs open).

[haslinghuis]

Thanks.

[hydra]

Just ran into this today, wondering why my make/local.mk was not picked up.

I disagree with this change. The principle behind the project structure that was setup in Cleanflight 10 years ago was so that newcomers to the project can easily navigate the project and not have to look in folders without being able to guess the content of the folder before opening it.

mk is an abbreviation, if you don't know about make using .mk as a file suffix you've got no idea what the heck is in a folder called mk.

make on the other hand is an English work that carries meaning, you can guess that there's stuff to do with making artifacts.

Changing the folder names as a workaround to an incorrectly setup environment, IMHO, is not the answer.

Please can we revert this?

[blckmn]

In a similar vane... you would presume that src should be source? or is there a lack of consistency in the approach?

[hydra]

In a similar vane... you would presume that src should be source? or is there a lack of consistency in the approach?

it's true, but that's because at the time I was coding a lot in Java and Groovy where 'src' is a common abbreviation

however, 'src' is a common abbreviation across ALL programming languages, whereas 'mk' is not, and the point still stands that using 'mk' to avoid a user-specific environment issue is a bad idea when for 10+ years using 'make' has been 100% fine for every developer so far.

[blckmn]

obj (for objects), bin (for binaries) ... the point is, shortening directory names is not uncommon and has been in practice for considerable time.

The fact is the make directory wasn't even introduced as part of cleanflight. It was Nathan Soi who introduced it 7 years ago (to add the arm_sdk_install target), and it was then further enhanced by myself and other contributors in betaflight.

I am not overly fussed to be honest - it can be renamed to make to satisfy your annoyance at the change - but let's not rewrite history.

[hydra]

The fact is the make directory wasn't even introduced as part of cleanflight. It was Nathan Soi who introduced it 7 years ago (to add the arm_sdk_install target), and it was then further enhanced by myself and other contributors in betaflight.

I am not overly fussed to be honest - it can be renamed to make to satisfy your annoyance at the change - but let's not rewrite history.

My bad, I'm mis-remembering it's origin. Carry on!