Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix g force calculation #12892

Merged
merged 1 commit into from Jun 17, 2023
Merged

Fix g force calculation #12892

merged 1 commit into from Jun 17, 2023

Conversation

Schuwi
Copy link
Contributor

@Schuwi Schuwi commented Jun 16, 2023

This line of code seems to have been lost in this refactor. Without it the G force indicator in the OSD only works until about 1.5-2G. When it gets any higher the value seems to accumulate and the OSD shows fluctuating garbage values of "0.xG" (x = random digit).

I tested the same code change on v4.4.2 and it worked, showing plausible values. I did not yet test it on master branch.

I did not manage to run either make pre-push or make unified_zip. Both failed with "No rule to make target [...]". Am I doing something wrong or is the PR preset just outdated?

@github-actions
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #12892 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@haslinghuis
Copy link
Member

make configs
make all_rev

should work

@haslinghuis haslinghuis added this to the 4.5 milestone Jun 16, 2023
@blckmn
Copy link
Member

blckmn commented Jun 16, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@blckmn blckmn merged commit c1694c2 into betaflight:master Jun 17, 2023
21 checks passed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants