Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rcSmoothing warning beeper #12893

Merged
merged 1 commit into from Jun 17, 2023
Merged

Fix rcSmoothing warning beeper #12893

merged 1 commit into from Jun 17, 2023

Conversation

haslinghuis
Copy link
Member

Fixes #12891

@haslinghuis haslinghuis added this to the 4.5 milestone Jun 17, 2023
@haslinghuis haslinghuis self-assigned this Jun 17, 2023
@github-actions
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #12893 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jun 17, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit d1eb214 into betaflight:master Jun 17, 2023
21 checks passed
@haslinghuis haslinghuis deleted the fix-rcsmoothing-warning branch June 17, 2023 23:49
@Schuwi Schuwi mentioned this pull request Jun 18, 2023
Closed
@haslinghuis haslinghuis changed the title Fix rcSmoothing warning Fix rcSmoothing warning beeper Jun 18, 2023
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Fix rcSmoothing warning (betaflight#12893)
5149753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@blckmn blckmn blckmn approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

@klutvott123 klutvott123 Awaiting requested review from klutvott123

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Permanent RCSMOOTHING OSD warning
4 participants
@haslinghuis @blckmn @McGiverGim @ctzsnooze