Fix Serial USB COM port #12911
Merged
Fix Serial USB COM port #12911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
haslinghuis
approved these changes
Jun 22, 2023
blckmn
requested changes
Jun 22, 2023
blckmn
approved these changes
Jun 22, 2023
|
Does anyone have a commit ID of when the USB serial was broken? Was a bisect done? I ask as I'm helping someone debug USB serial issues and want to know a range of bad commits to see if he was testing with known-broken code. |
Yes i have it somewhere, it was the LPUART/SOFTSERIAL refactoring from DieHertz |
freasy
added a commit
to freasy/betaflight
that referenced
this pull request
Jul 19, 2023
davidbitton
pushed a commit
to davidbitton/betaflight
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the softserial rework, when a target does not have "USE_SOFTSERIAL" the identifier for softserial will not be set to "none", thus somehow breaks the virtual com port.