Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AT32F435 camera control #12913

Merged
merged 4 commits into from Jul 10, 2023
Merged

AT32F435 camera control #12913

merged 4 commits into from Jul 10, 2023

Conversation

freasy
Copy link
Member

@freasy freasy commented Jun 23, 2023 •
edited

Adds camera control to at32

@github-actions
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #12913 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@haslinghuis haslinghuis added this to the 4.5 milestone Jun 23, 2023
@blckmn
Copy link
Member

blckmn commented Jun 23, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

SteveCEvans
SteveCEvans requested changes Jun 23, 2023
View reviewed changes
src/main/drivers/camera_control.c Outdated Show resolved Hide resolved
src/main/target/AT32F435G/target.h Outdated Show resolved Hide resolved
src/main/target/AT32F435M/target.h Outdated Show resolved Hide resolved
@freasy
Copy link
Member Author

freasy commented Jun 26, 2023 •
edited

Tested with NeutronRCF435 and RunCam phoenix 2, working flawless

@blckmn blckmn merged commit 214946b into betaflight:master Jul 10, 2023
22 checks passed
freasy added a commit to freasy/betaflight that referenced this pull request Jul 19, 2023
@freasy
AT32F435 camera control (betaflight#12913)
316a5ea 
* [AT32] camera control

* remove comments

* change to mcu specific implementation

* fix includes
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@freasy @davidbitton
AT32F435 camera control (betaflight#12913)
5ece424 
* [AT32] camera control

* remove comments

* change to mcu specific implementation

* fix includes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@nerdCopter nerdCopter nerdCopter left review comments

@ASDosjani ASDosjani ASDosjani left review comments

@KarateBrot KarateBrot KarateBrot requested changes

@haslinghuis haslinghuis haslinghuis approved these changes

@SteveCEvans SteveCEvans Awaiting requested review from SteveCEvans

@klutvott123 klutvott123 Awaiting requested review from klutvott123

Assignees

@freasy freasy

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@freasy @blckmn @haslinghuis @SteveCEvans @KarateBrot @nerdCopter @ASDosjani