Handle USART TX pulldown #12929
Merged
Handle USART TX pulldown #12929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
|
AUTOMERGE: (FAIL)
|
ledvinap
reviewed
Jun 27, 2023
| @@ -315,7 +315,7 @@ uartPort_t *serialUART(UARTDevice_e device, uint32_t baudRate, portMode_e mode, | |||
| if ((mode & MODE_TX) && txIO) { | |||
| IOInit(txIO, OWNER_SERIAL_TX, RESOURCE_INDEX(device)); | |||
|
|
|||
| if ((options & SERIAL_INVERTED) == SERIAL_NOT_INVERTED) { | |||
| if (((options & SERIAL_INVERTED) == SERIAL_NOT_INVERTED) && !(options & SERIAL_BIDIR_PP_PD)) { | |||
There was a problem hiding this comment.
It may be better to add new bit to options, signaling that uartTxMonitor shall be used
|
Tramp VTX confirmed working |
|
MSP VTX on BETAFPVF435 with an Avatar 1S VTX confirmed working. Many thanks! |
SA is always unidirectional Only switch AT32 TX line to input when transmission is complete
|
Tested with S.Bus using Futaba T8FG TX and Redcon FT4X clone FASST S.Bus RX using Revo Nano. |
freasy
approved these changes
Jul 1, 2023
haslinghuis
approved these changes
Jul 1, 2023
blckmn
approved these changes
Jul 2, 2023
klutvott123
approved these changes
Jul 2, 2023
freasy
pushed a commit
to freasy/betaflight
that referenced
this pull request
Jul 19, 2023
SA is always unidirectional Only switch AT32 TX line to input when transmission is complete
davidbitton
pushed a commit
to davidbitton/betaflight
that referenced
this pull request
Feb 5, 2024
SA is always unidirectional Only switch AT32 TX line to input when transmission is complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12760 would stall transmission if the TX line was pulled down, but SmartAudio uses a pulldown, do don't use this behaviour under such circumstances.
Also, always configure SmartAudio to be bi-directional.