Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert 12577 change for F4 #12969

Merged
merged 1 commit into from Jul 21, 2023
Merged

Revert 12577 change for F4 #12969

merged 1 commit into from Jul 21, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jul 18, 2023 •
edited

Fixes GPS unit's not able to connect after #12577

For more details please check: #12972

@haslinghuis haslinghuis added this to the 4.5 milestone Jul 18, 2023
@haslinghuis haslinghuis self-assigned this Jul 18, 2023
@github-actions
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #12969 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@haslinghuis
Copy link
Member Author

image

@blckmn
Copy link
Member

blckmn commented Jul 18, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis mentioned this pull request Jul 19, 2023
Closed
@blckmn blckmn merged commit 293e14e into betaflight:master Jul 21, 2023
24 checks passed
@haslinghuis haslinghuis deleted the fix-serial branch July 21, 2023 08:46
freasy pushed a commit to freasy/betaflight that referenced this pull request Jul 22, 2023
@haslinghuis @freasy
Revert 12577 change for F4 (betaflight#12969)
b396ab4
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Revert 12577 change for F4 (betaflight#12969)
56862fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@klutvott123 klutvott123 Awaiting requested review from klutvott123

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

@SteveCEvans SteveCEvans Awaiting requested review from SteveCEvans

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: BUGFIX Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haslinghuis @blckmn @ctzsnooze