Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OSD quick menu #12977

Merged
merged 9 commits into from Jul 25, 2023
Merged

Adding OSD quick menu #12977

merged 9 commits into from Jul 25, 2023

Conversation

limonspb
Copy link
Member

@limonspb limonspb commented Jul 21, 2023

Feature well-adopted in special release KAACK and beloved by racers.
If defined USE_OSD_QUICK_MENU can use in CLI:
set osd_use_quick_menu = ON
This activates quick menu that replaces the main menu as a first CSM page.
PR also adds PRM limit OSD menu (if defined)
PR also replaces EXIT with SAVE&EXIT in VTX menu. Because it's annoying you have to quit from all menus after you have changed the channel - takes more time.
image

@github-actions
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #12977 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jul 21, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

src/test/Makefile Outdated Show resolved Hide resolved
@limonspb limonspb requested a review from blckmn July 25, 2023 22:44
@blckmn blckmn merged commit 9332248 into betaflight:master Jul 25, 2023
23 checks passed
freasy pushed a commit to freasy/betaflight that referenced this pull request Aug 14, 2023
* QUICK CMS menu

* Added RPM LIMIT to quick menu

* rpm_limiter csm step = 100

* Renamings + USE_OSD_QUICK_MENU define

* Small fixes

* Style fixes

* tests makefile fix

* Activate quick menu by default, if defined USE_OSD_QUICK_MENU

* Changed .c/.h license headers to a modern one
@sanderpuh
Copy link

Betaflight 4.5 release notes has the custom define specified as QUICK_MENU, this commit has it specified as OSD_QUICK_MENU and for me it only worked when I specified it as QUICK_OSD_MENU

@haslinghuis
Copy link
Member

haslinghuis commented Jan 5, 2024

Correct. See: http://betaflight.com/docs/development/API/Cloud-Build-API

Corrected in PR below and in documentation now (awaiting approval)

davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
* QUICK CMS menu

* Added RPM LIMIT to quick menu

* rpm_limiter csm step = 100

* Renamings + USE_OSD_QUICK_MENU define

* Small fixes

* Style fixes

* tests makefile fix

* Activate quick menu by default, if defined USE_OSD_QUICK_MENU

* Changed .c/.h license headers to a modern one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

5 participants