Remove dshot_telemetry_start_margin setting to use auto-tune(#13075) #13082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taflight#13075) * Remove dshot_telemetry_start_margin setting and auto-tune instead * Add USE_DSHOT_BITBAND
|
original PR to master contained other F4 |
|
4.4.x does not contain AT32 target support. |
|
Has this been tested? |
|
@damosvil , can you test this for 4.4.x lease? i cannot for several days. |
|
It seems to be working fine on my side |
nerdCopter
previously approved these changes
Sep 20, 2023
haslinghuis
requested review from
blckmn,
SteveCEvans,
KarateBrot and
klutvott123
SteveCEvans
requested changes
Sep 20, 2023
|
|
||
|
|
||
| uint32_t decode_bb(uint16_t buffer[], uint32_t count, uint32_t mask); | ||
| #if defined(STM32F4) || defined(AT32F4) |
There was a problem hiding this comment.
Shouldn’t this use #ifdef USE_DSHOT_BITBAND?
There was a problem hiding this comment.
Thanks. Good catch. Fixed.
nerdCopter
approved these changes
Sep 20, 2023
blckmn
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synchronizing #13075 to 4.4-maintenance