-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drive TX line high before switching to input #13098
Conversation
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
AUTOMERGE: (FAIL)
|
The unit tests are working for me running under Linux.
Whereas the cloud build is:
|
81c040a
to
8c14c97
Compare
@haslinghuis As you'll see I've made a number of commits to fix some, but not all of the unit tests. Something is broken around the definition of |
Clang versions has been updated in the workflow image: actions/runner-images#8329 EDIT: should be fixed using #13099 |
bddb8b7
to
07ab645
Compare
Unit test changes backed out as this is not the place to fix that issue. |
@dxs94 Thanks for testing. I've just pushed a commit which adds a new debug mode, Could you please log with that. I presume this is still on an F4? This will log the following:
If we see |
Hi yes still the same F411 board from GEPRC P16 as in #12902. Unfortunately no black box on this one so no logging :( |
In light of testing there are evidently issues with some receivers so closing this and moving to #13100. |
This PR attempts to fix the issues tackled by #13095.
The proposed solution mentioned at #13095 (comment) of only disabling the TX output once at 100ms have passed since a received character, resulted in the original issue resurfacing which was the FC dropping into DFU mode when a connected WS VTX was powered off.
The PR drives the TX line high with a pull-up before switching to an input with a pull-up. For #13095 to have any positive effect it must be either preventing the TX being sampled low, or the TX line is actually being pulled down by the attached device. This PR addresses the former.
@dxs94 could you please test this PR and report back.