Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ESCSERIAL from F7X2 targets #13221

Closed
wants to merge 1 commit into from

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 12, 2023

Fixes #13220
Reverts #13078

According to comment in #12992 escserial does not work on F7 targets.

Think we need to remove USE_ESCSERIAL define from the F7 target for now.

@haslinghuis haslinghuis added this to the 4.5 milestone Dec 12, 2023
@haslinghuis haslinghuis self-assigned this Dec 12, 2023
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #13221 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Dec 12, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@Quick-Flash
Copy link
Contributor

Quick-Flash commented Dec 12, 2023

According to comment in #12992 escserial does not work on F7 targets.

Actually, according to that pull request it may work on F7 it is simply untested.

@McGiverGim
Copy link
Member

What implies this? It's only used for passthrough for Kiss or it's needed to flash other ESCs like blheli32? To test it.

@SteveCEvans
Copy link
Member

ESC_SERIAL works fine on the F7s. I use it myself where I'm using T-Motor ESCs with a BEC. I then power the FC from the BEC and need ESC-SERIAL to get the battery voltage.

We won't be removing it.

@haslinghuis haslinghuis deleted the remove-escserial branch December 13, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

Kiss passthrough is broken
5 participants