revert msp method for gps sat info messages #13245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
|
First : #13244 |
|
#13244 is not required before this PR. |
ctzsnooze
requested review from
blckmn,
haslinghuis,
SteveCEvans and
sugaarK
ctzsnooze
commented
Dec 27, 2023
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| #include "gps.h" | |||
|
|
|||
| PG_REGISTER_WITH_RESET_TEMPLATE(gpsConfig_t, gpsConfig, PG_GPS_CONFIG, 4); | |||
| PG_REGISTER_WITH_RESET_TEMPLATE(gpsConfig_t, gpsConfig, PG_GPS_CONFIG, 3); | |||
There was a problem hiding this comment.
The variables for the GPS PG were not changed in PR #13240, so the PG did not increasing from 3 to 4 in that PR.
This PR is basically a reversion of 13240, and it seems correct to keep the PG at 3, especially since nothing changed.
However, if it is best to keep it at 4 please let me know.
|
AUTOMERGE: (FAIL)
|
|
closing since required changes are now all in PR #13244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the reliable sending of SatInfo data from the GPS module on power up, which was lost with PR #13240.
Any version of Configurator should reliably see satellite info on connecting a firmware 4.5 quad to betaflight. There is no requirement to have the latest nightly version of Configurator. Sat info data will be sent by the GPS once it has established a serial connection and once the early configuration is complete, typically about 2s after powering up. Then, on arming, a message is sent to the module to tell it to stop sending the Satellite Info data.
This achieves the same effective outcome as the code before PR #13240, which it largely reverts, but does not require Configurator to be connected within a certain time at the start. The module will just get told to send satellite info until it is armed. After that, no more Satellite info until a power cycle.
it is a simpler alternative to #13244, which introduces a CLI value to change the time for the check for whether Configurator is connected.
I've tested it and it works. Sat info is reliably displayed by all Configurator versions back to 10.8, and stops on arming.
There may be a possible user interest in re-enabling the Sat Info on disarming, but I don't see it being an issue at this point in time. And previously it was not possible to re-enable the data.
Nor should there be a problem if we send SatInfo data from the time the module turns on.