Nonblocking w25n01g code tidy up

[SteveCEvans]

Follow on from #13555

[github-actions]

Do you want to test this code? You can flash it directly from Betaflight Configurator:

• Simply put #13562 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

[ledvinap]

can you merge upstream/master, please? it should remove conflicts

[nerdCopter]

went fly this (5cdae1b) on non-affected target. figured it was the least i could do after effing up. logs were in-tact for APEXF7 W25Q128FV.

[nerdCopter]

@SteveCEvans , this branch has merge conflicts. merging master (or rebase) will fix.

[nerdCopter]

commit 6837ed2 needs closing #endif's

[SteveCEvans]

commit 6837ed2 needs closing #endif's

Yup, rather daft copy-n-paste error!

[nerdCopter]

adding my approval for workflow, but hoping others will deep-inspect.

[haslinghuis]

Small log using 8K logging:

BTFL_BLACKBOX_LOG_20240422_213304_SDMODELH7.zip

[haslinghuis]

@ledvinap please test

[ledvinap]

(maybe it would be more readable if command buffers were closer to segments (intermix them) )

[ledvinap]

fdevice->io.handle.dev union member is used, but device can be in quad/octo mode.

if (fdevice->io.mode == FLASHIO_SPI) {

[ledvinap]

@SteveCEvans :
Both gcc and clang support initialization of structure flexible member. With it, segments can be refactored, removing union and making code cleaner overall. dev will point to current segments, linking and skipping will be easier, it will save some memory.

I'd also pass segment index and busSegment_t* to callback (making it common for whole chain) and add flags to each buffers[] entry(skip, possibly last, etc), but that is personal preference ...

typedef struct busSegment_s {
        struct {
            // device associated with THIS transfer
            const extDevice_t *dev;
            // Segments to process in the next transfer.
            volatile struct busSegment_s *next;
            int segmentcount;  // number of segments in this block
        } head;
        struct {
            // Transmit buffer
            uint8_t *txData;
            // Receive buffer, or in the case of the final segment to
            uint8_t *rxData;
            int len;
            bool negateCS; // Should CS be negated at the end of this segment
            busStatus_e (*callback)(uint32_t arg);
        } buffers[];
} busSegment_t;