Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turtle/Flip after crash: Add options to use all the motors #5600

Merged
merged 1 commit into from Apr 6, 2018

Conversation

brycedjohnson
Copy link
Contributor

@brycedjohnson brycedjohnson commented Apr 1, 2018

Added crashflip_motor_percent. This will use the other motors while doing a turtle. This is typically only useful on lower power ducted quads. Setting to 0 will use just 2 motors which is the default. 50-70% seemed to work for getting a brushless tinywhoop flipped over easier.

Quick test here: Helps a lot!
http://www.youtube.com/watch?v=Qwh1MBNnZj4

Tinywhoop.com helped me with some motors and frames to test!

@brycedjohnson brycedjohnson changed the title Add options to use all the motors Turtle/Flip after crash: Add options to use all the motors Apr 1, 2018


if (motorOutput < 0 && mixerConfig()->crashflip_motor_percent > 0)
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brace on the same line as the condition please, only functions use braces on a new line (K & R style).


if (motorOutput < 0 && mixerConfig()->crashflip_motor_percent > 0)
{
motorOutput = -motorOutput * (float)mixerConfig()->crashflip_motor_percent/100.0f;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces around operators please.

@brycedjohnson
Copy link
Contributor Author

Got a bug with this right now, going to fix it...

@brycedjohnson
Copy link
Contributor Author

brycedjohnson commented Apr 4, 2018

It is fixed now.

mikeller
mikeller previously approved these changes Apr 4, 2018
@mikeller
Copy link
Member

mikeller commented Apr 5, 2018

Rebase after #5627 has been merged - that should fix the overflow.

@mikeller mikeller merged commit 588addd into betaflight:master Apr 6, 2018
ethomas997 added a commit to ethomas997/betaflight that referenced this pull request Apr 10, 2018
From:  Turtle/Flip after crash: Add options to use all the motors betaflight#5600
betaflight#5600
@brycedjohnson brycedjohnson deleted the AllMotorTurtle2 branch April 28, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants