New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled timer management for all F405 / F722 boards. #7620
Enabled timer management for all F405 / F722 boards. #7620
Conversation
7dc4ce8
to
17ae1d0
Compare
@jflyper: My last commit adds support for configurable DMA options for timers. Can you please review? N.b.: The conversion to actually use configurable DMA options has only been done for Dshot, other consumers of timer pin resources will have to be modified as well. Also, currently CLI only prints the timer DMA options, setting them will have to be done. (Suggestion: use |
59e4359
to
254a05b
Compare
Ok, I think this is pretty much ready to go in now. What it does:
What it does not do:
|
8bb1195
to
cf41bce
Compare
cf41bce
to
650e0df
Compare
Rebased & squashed. This is the last call for reviews. There is more work stacked up behind this, and waiting longer will jeopardise the feature freeze for the 4.0 release, so if nobody wants to review this I'll merge it. |
650e0df
to
331dcbd
Compare
…r all F4 boards. Converting the universal target as well. Simplified timer management some. Added F722 support for good measuer. Fixed SITL, tests. Cleanup after rebase. Added support for all timer consumers and F7. Fixed 'USE_DMA_SPEC' for F3, some cleanups.
331dcbd
to
f8103b8
Compare
One thing I'm not sure about is the
The part at the end that lists the pins and the verbose stream/channel info seems to generate output that won't work as commands. For example:
|
Also looks like some better handling of missing parameters is needed as it looks like we're printing a buffer overflow.
|
This is a known limitation: This pull request does not yet support reading back the pin |
Will fix the overflow in #7672. |
This is a proposal to, instead of only enabling timer management on unified targets, enable it for all targets with MCUs that have had full lists of all timer / pin combinations generated (stored in
fullTimerHardware
). Motivation for this:timer list
output has been added to thediff
/dump
output, all it will take is adump
with non-hardware-related parts deleted to serve as a unified target config;master
.It is currently incomplete as any non-standard DMA options encoded in target definitions as part of
timerHardware
are ignored - supporting these will require support for configurable DMA options for timers that @jflyper is working on.