Fixed PWM beeper. #7891
Merged
Fixed PWM beeper. #7891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etracer65
approved these changes
Mar 28, 2019
Doh!!! 馃槗 I would start calling it a zombie. |
|
@jflyper: 'Zombie' is what I felt like after the bisect... But at least the mystery is solved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added
beeper_frequencyas aHARDWARE_VALUE, since this is required to make PWM beepers work (and avoid running DC through them).Also added the Unified Target config for the CLRACINGF4, and a manufacturer id for CLRACING.
@jflyper: Turns out this was caused by PWM beeper having been missed for #6681, which took me a bisect between 3.5 and 4.0 to find. 馃槄