Fix pageMaxRow use before update #8222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After commit d2e7abd the for loop following my change use pageMaxRow to determine which flags to clear. But this pageMaxRow value is updated after the loop, which caused a crash in a very specific circumstance: 1 open the CMS OSD menu and go to profile 2 close the profile by yaw right, select exit 3 open CMS OSD menu and go to profile again This caused a crash as runtimeEntryFlags wasn't cleared properly and the Copy Profile entry's flags still indicated OPTSTRING somehow. which caused it's CMSEntryFuncPtr function to be cast to OPTSTRING and called without arguments.
mikeller
approved these changes
May 8, 2019
mikeller
added a commit
that referenced
this pull request
May 9, 2019
Fix pageMaxRow use before update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit d2e7abd the for loop following my change use pageMaxRow to determine which flags to clear.
But this pageMaxRow value is updated after the loop, which caused a crash in a very specific circumstance:
1 open the CMS OSD menu and go to profile
2 close the profile by yaw right, select exit
3 open CMS OSD menu and go to profile again
This caused a crash as runtimeEntryFlags wasn't cleared properly and the Copy Profile entry's flags still indicated OPTSTRING somehow.
which caused it's CMSEntryFuncPtr function to be cast to OPTSTRING and called without arguments.