Disable CMS Tramp menu if other VTX device configured #9134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize that this is unusual in that the PR is against the
4.1-maintenance
branch, but this has already been fixed in a more comprehensive way for 4.2 in #9066. However we have an ongoing support problem in that the CMS Tramp VTX menu presents what appears to be a functional menu that can change channels and bands even if the user has configured a SmartAudio device. This results in a lot of confusion. If the SA device is actually working, then the band/channel/power settings worked since the affected thevtx_common
layer. But the status line does not display (because the vtx isn't Tramp). If the SA device wasn't working, then the user can still change the band/channel/power thinking they're doing someone but they are having no affect.This PR updates the CMS Tramp menu to present a "disabled" menu with all 0 values that prevents changing settings if the VTX device is not configured as Tramp. Also the status message reports "TRAMP NOT CONFIGURED" to help the user identify they're using the wrong menu. For example:
None of the settings can be changed and the "Set" to save the settings is disabled.
This is meant to be an interim workaround for 4.1 as it's improved with an automatic menu selection in 4.2.