Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CMS Tramp menu if other VTX device configured #9134

Merged

Conversation

etracer65
Copy link
Member

I realize that this is unusual in that the PR is against the 4.1-maintenance branch, but this has already been fixed in a more comprehensive way for 4.2 in #9066. However we have an ongoing support problem in that the CMS Tramp VTX menu presents what appears to be a functional menu that can change channels and bands even if the user has configured a SmartAudio device. This results in a lot of confusion. If the SA device is actually working, then the band/channel/power settings worked since the affected the vtx_common layer. But the status line does not display (because the vtx isn't Tramp). If the SA device wasn't working, then the user can still change the band/channel/power thinking they're doing someone but they are having no affect.

This PR updates the CMS Tramp menu to present a "disabled" menu with all 0 values that prevents changing settings if the VTX device is not configured as Tramp. Also the status message reports "TRAMP NOT CONFIGURED" to help the user identify they're using the wrong menu. For example:

tramp_cms_menu_disabled

None of the settings can be changed and the "Set" to save the settings is disabled.

This is meant to be an interim workaround for 4.1 as it's improved with an automatic menu selection in 4.2.

Present a "disabled" menu with all 0 values that prevents changing settings if the VTX dvice is not configured as Tramp.
@etracer65 etracer65 added this to the 4.1.1 milestone Oct 30, 2019
@etracer65
Copy link
Member Author

Also tested with a Tramp vtx to confirm that it still functions normally.

@mikeller
Copy link
Member

Still a considerable amount of code that is needed to work around this. ☹️

@etracer65
Copy link
Member Author

Looks like more than it really is though. Mostly just wrapping a if (!trampDeviceConfigured) around code blocks but the diff makes it look like more.

@etracer65
Copy link
Member Author

And all this goes away in 4.2.

@mikeller mikeller merged commit 68a62cf into betaflight:4.1-maintenance Nov 1, 2019
@etracer65 etracer65 deleted the cms_block_tramp_menu branch December 4, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants