Fixed potentially incorrect calculation in ACC calibration if non-default cycle number is used. #9177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etracer65
previously approved these changes
Nov 16, 2019
|
Tests failed. |
…ault cycle number is used.
mikeller
force-pushed
the
fix_acc_calibration
branch
from
87b9b32
to
a21d0f5
Compare
|
@etracer65: Tests fixed. |
etracer65
approved these changes
Nov 16, 2019
mikeller
added a commit
that referenced
this pull request
Nov 17, 2019
Fixed potentially incorrect calculation in ACC calibration if non-default cycle number is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the problem of
CALIBRATING_ACC_CYCLESbeing hard coded into the calculation of the calibration results.