Add option to display the OSD logo on arming #9244
Conversation
Adds `osd_logo_on_arming` setting with values `OFF, ON, FIRST_ARMING` (defaults to `OFF`). Optionally displays the OSD splash logo durin the "ARMING" message.
|
Awesome! With a pit switch i never see my logo. Thanks etracer65! |
Adds `osd_logo_on_arming_duration` which is configured in 0.1s intervals ranging from 5 to 50 (0.5s to 5.0s). The default is 5 (0.5s) to be consistent with the previous "ARMED" splash screen.
|
Pushed a commit to add configurable display duration. |
| { | ||
| static bool everArmed = false; |
There was a problem hiding this comment.
I wonder if this could be replaced by checking ARMING_FLAG(WAS_EVER_ARMED). It will need some refactoring, but I can have a look into it.
There was a problem hiding this comment.
No, I originally tried that. But by the time we get to this code we are already armed and ARMING_FLAG(WAS_EVER_ARMED) is already true.
|
@etracer65 Can be allow 300x160 pixels for the logo? In such a way that it can be shown bigger and centered? |
|
@asizon No, the resolution cannot be changed. Also the logo is positioned the same as at boot time and must make room for the "ARMED" message which is the actual point of the momentary display at arming. The logo is a "nice to have" but doesn't get priority. |
|
@asizon: The 'logo' is actually made up of characters that are part of the character set that is uploaded to the MAX7456 OSD chip. So the only way to make the logo bigger is to increase the number of characters reserved for the logo. Since there are not many unused characters at the moment there is no easy way to achieve this with current hardware. |
|
@etracer65 @mikeller Understood, thanks for the explanation, I was afraid that there will be no free characters for easy logo expand, then maybe later, in the near future |
By user request.
Adds
osd_logo_on_armingsetting with valuesOFF, ON, FIRST_ARMING(defaults toOFF). Optionally displays the OSD splash logo during the "ARMING" message.The duration that the logo displays can be set with
osd_logo_on_arming_durationwhich is configured in 0.1s intervals ranging from 5 to 50 (0.5s to 5.0s). The default is 5 (0.5s) to be consistent with the previous "ARMED" splash screen.Allows custom logos to be recorded on DVR and useful for spectators at races. Might also increase uptake on the custom logo capability in the Configurator.