[MSP] Correctly report the configured and active OSD type #9333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiam
added a commit
to fiam/betaflight-configurator
that referenced
this pull request
Jan 3, 2020
Use the flags added in betaflight/betaflight#9333 to detect wether the font manager dialog should be shown. This FrSkyOSD fixes the bug that was preventing the Font Manager dialog to be shown when FrSky OSD was in use.
- Tell the OSD driver the type of displayPort, so it can be retrieved later. - Use OSD driver code instead of device specific code to handle MSP_OSD_CONFIG response while minimizing driver specific code. - Add flag for signaling the use of FrSky OSD (bit 3). - Rename OSD_FLAGS_MAX7456_DETECTED to OSD_FLAGS_OSD_DEVICE_DETECTED. Since we only support one OSD device type at a time, we can use the same bit to signal wether the hardware has been detected.
|
Could someone take a look at this one? It's needed, coupled with betaflight/betaflight-configurator#1852, to support font uploads for devices that support MAX7456 fonts but are not a MAX7456 (like FrSky OSD). |
mikeller
approved these changes
Jan 13, 2020
|
Thanks @mikeller! |
fiam
added a commit
to fiam/betaflight-configurator
that referenced
this pull request
Jan 16, 2020
Use the flags added in betaflight/betaflight#9333 to detect wether the font manager dialog should be shown. This FrSkyOSD fixes the bug that was preventing the Font Manager dialog to be shown when FrSky OSD was in use.
fiam
added a commit
to fiam/betaflight-configurator
that referenced
this pull request
May 25, 2020
Use the flags added in betaflight/betaflight#9333 to detect wether the font manager dialog should be shown. This fixes the that was preventing the Font Manager dialog to be shown when FrSky OSD was in use.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
later.
MSP_OSD_CONFIG response while minimizing driver specific code.
Since we only support one OSD device type at a time, we can use the
same bit to signal wether the hardware has been detected.