Exclude SWD pins from being initialised as pull up if unused. #9420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etracer65
previously approved these changes
Jan 27, 2020
|
Builds are failing for F405. Looks like we need some conditionals on the pins used? |
jflyper
requested changes
Jan 27, 2020
src/main/fc/init.c
Outdated
| { | ||
| sdcard_init(sdcardConfig()); | ||
| afatfs_init(); | ||
| } | ||
| #endif | ||
|
|
||
| static void swdPinsInit(void) | ||
| { | ||
| IO_t io = IOGetByTag(IO_TAG(PA13)); // SWDIO |
There was a problem hiding this comment.
DEFIO_TAG_E instead of IO_TAG for targets that doesn't even define these pins as available in TARGET_IO_PORTA?
src/main/fc/init.c
Outdated
| if (IOGetOwner(io) == OWNER_FREE) { | ||
| IOInit(io, OWNER_SWD, 0); | ||
| } | ||
| io = IOGetByTag(IO_TAG(PA14)); // SWCLK |
mikeller
force-pushed
the
exclude_swd_pins_from_pullup
branch
from
b2d19bf
to
35cdb23
Compare
mikeller
force-pushed
the
exclude_swd_pins_from_pullup
branch
from
35cdb23
to
cd27b63
Compare
|
Building now. |
etracer65
approved these changes
Jan 28, 2020
|
@jflyper: Are you happy with this now? |
jflyper
approved these changes
Jan 31, 2020
mikeller
added a commit
that referenced
this pull request
Mar 23, 2020
Exclude SWD pins from being initialised as pull up if unused.
mikeller
added a commit
that referenced
this pull request
Mar 28, 2020
Exclude SWD pins from being initialised as pull up if unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the functionality to what it was before #9398: No pull up is configured for the SWD pins if they are unused.