Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI LED command validation #9546

Merged
merged 1 commit into from Mar 7, 2020
Merged

Fix CLI LED command validation #9546

merged 1 commit into from Mar 7, 2020

Conversation

etracer65
Copy link
Member

Previous validation failed to catch negative numbers for the LED index. For example:

# led -1 0,0::c:0
led 4294967295 0,0:WU:C:0

After the fix:

# led -1 0,0::c:0
###ERROR: INDEX NOT BETWEEN 0 AND 31###

@etracer65 etracer65 added this to the 4.1.5 milestone Mar 5, 2020
@mikeller mikeller merged commit c002d04 into betaflight:master Mar 7, 2020
mikeller added a commit that referenced this pull request Mar 7, 2020
@mikeller
Merge pull request #9546 from etracer65/fix_cli_led_validation
c7a1f7c 
Fix CLI LED command validation
This was referenced Mar 7, 2020
Closed
Merged
@etracer65 etracer65 deleted the fix_cli_led_validation branch June 2, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeller mikeller mikeller approved these changes

Assignees
No one assigned
Labels
RN: BUGFIX
Projects
None yet
Milestone
4.1.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etracer65 @mikeller