Prevent possible buffer overrun in MSPv2 message parsing #9780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MSPv2 parsing was missing a check (present in v1) to prevent a possible buffer overrun if the payload exceeded the buffer size. Also some code formatting cleanup.
|
Note that this is not related to the "64 byte USB bug". Just something I found while tracing through the code. |
mikeller
approved these changes
May 9, 2020
kotAPI
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSPv2 parsing was missing a check (present in v1 code) to prevent a possible buffer overrun if the payload exceeded the buffer size. The buffer overrun is not likely in normal circumstances since 192 bytes are allocated, but could be triggered through message corruption with invalid size data.
Also some code formatting cleanup.