Fixed pin ownership checks for I2C. #9810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9806.
This fixes the problem that currently,
IOInit()
does not check if a pin is already used (i.e. has an owner assigned) before setting the owner. This leads to cases where a pin is successfully assigned and a pin function started, but then the pin gets re-assigned to a different function, leaving artefacts:Setup:
Before:
After:
This is just one fix to solve a problem that is currently breaking configurations for users. A comprehensive switch to replace
IOInit()
with functionality that checks resource ownership is needed, and is currently work in progress, to be added after 4.2 has been released.Also removing a duplicate
RCC_ClockCmd()
line.Test firmware:
betaflight_4.2.0_STM32F745_37209b4826.zip
betaflight_4.2.0_STM32F7X2_37209b4826.zip
betaflight_4.2.0_STM32F411_37209b4826.zip
betaflight_4.2.0_STM32F405_37209b4826.zip
(installation instructions: youtu.be/I1uN9CN30gw)