Refactored Dshot enabled checks. #9937
Conversation
src/main/drivers/dshot_command.h
Outdated
| @@ -73,4 +73,4 @@ bool dshotCommandQueueEmpty(void); | |||
| bool dshotCommandIsProcessing(void); | |||
| uint8_t dshotCommandGetCurrent(uint8_t index); | |||
| bool dshotCommandOutputIsEnabled(uint8_t motorCount); | |||
| bool dshotCommandsAreEnabled(dshotCommandType_e commandType); | |||
| bool dshotStreamingCommandsAreEnabled(); | |||
There was a problem hiding this comment.
Is think you forgot (void) ?
There was a problem hiding this comment.
line 75 puzzles me; still using this function in dshot_command.c , maybe it is declared in another header file?
There was a problem hiding this comment.
Fixed. Not sure what is puzzling about line 75?
There was a problem hiding this comment.
Sorry I mean removing line 76, it looks to me declaration of function bool dshotCommandsAreEnabled(dshotCommandType_e commandType); is still used?
There was a problem hiding this comment.
It's only used internally, so it's not part of the interface of the unit (i.e. the header file) any more.
There was a problem hiding this comment.
Changing the function declaration to static should already have told me this was for internal use only. Thanks for solving my little puzzle 🥇
mikeller
force-pushed
the
refactor_dshot_enabled_checks
branch
from
0741235
to
cdf63f3
Compare
mikeller
force-pushed
the
refactor_dshot_enabled_checks
branch
from
cdf63f3
to
c2812ec
Compare
No description provided.