Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bmi270 filter settings #141

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Add bmi270 filter settings #141

merged 1 commit into from
Jan 5, 2022

Conversation

DusKing1
Copy link
Contributor

@DusKing1 DusKing1 commented Jan 5, 2022

No description provided.

@DusKing1 DusKing1 force-pushed the add-bmi270-filter-settings branch 4 times, most recently from 8c38ad8 to 3993baf Compare January 5, 2022 07:33
limonspb
limonspb previously approved these changes Jan 5, 2022
View reviewed changes
@limonspb
Copy link
Member

limonspb commented Jan 5, 2022

some test on the old BF4.3 are here:
#47

for future, we can redo the test on release 4.3, but for now, i think, this preset could be experimental, and let's see the feedback.

KarateBrot
KarateBrot previously approved these changes Jan 5, 2022
View reviewed changes
@DusKing1 DusKing1 dismissed stale reviews from KarateBrot and limonspb via 5fdbae1 January 5, 2022 11:49
@limonspb limonspb merged commit 159c40d into betaflight:master Jan 5, 2022
@DusKing1 DusKing1 deleted the add-bmi270-filter-settings branch January 6, 2022 00:40
rochford77 added a commit to rochford77/firmware-presets that referenced this pull request Feb 2, 2022
@rochford77
Squashed commit of the following:
436c31d 
commit e20300c
Merge: cb65349 0407056
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sun Jan 30 22:27:07 2022 -0600

    Merge pull request betaflight#177 from limonspb/supa_fix

    removing set simplified_dterm_filter_multiplier = 0 from Supa tunes

commit 0407056
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sun Jan 30 21:44:55 2022 -0600

    removing set simplified_dterm_filter_multiplier = 0 from Supa tunes

commit cb65349
Merge: 46905e7 780f868
Author: sugaarK <skunkworksbikes@gmail.com>
Date:   Sun Jan 30 21:04:25 2022 +1100

    Merge pull request betaflight#174 from limonspb/ayykayy

    AyyyKayyy 1S whoop race tune

commit 46905e7
Merge: b5e1bd3 1bf4e93
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sat Jan 29 21:08:53 2022 -0600

    Merge pull request betaflight#175 from FPVian/fpvian-submit

    Added Force_Options_Review Setting

commit 1bf4e93
Author: FPVian <96704941+FPVian@users.noreply.github.com>
Date:   Sat Jan 29 17:33:30 2022 -0500

    Added Force_Options_Review Setting

commit 780f868
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Fri Jan 28 22:37:53 2022 -0600

    AyyyKayyy whoop race tune

commit b5e1bd3
Merge: b7696e5 a5f9fe3
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Thu Jan 27 04:42:13 2022 -0600

    Merge pull request betaflight#173 from limonspb/mandate

    Add #$ FORCE_OPTIONS_REVIEW: TRUE/FALSE (optional)

commit a5f9fe3
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Tue Jan 25 03:44:44 2022 -0600

    Add #: TRUE/FALSE options (optional)

commit b7696e5
Merge: a2a33f4 790cff6
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Thu Jan 20 00:56:33 2022 -0600

    Merge pull request betaflight#169 from NemesisXB/diatone_mamba_ultra1000

    Update diatone mamba ultra 1000 with option_group

commit a2a33f4
Merge: ec3eb32 e2f39f0
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Thu Jan 20 00:56:10 2022 -0600

    Merge pull request betaflight#170 from NemesisXB/speedybee_tx800

    Update Speedybee TX800 with OPTION_GROUP for Regulatory Domain

commit ec3eb32
Merge: 730638d d19f7be
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Thu Jan 20 00:55:18 2022 -0600

    Merge pull request betaflight#172 from FPVian/fpvian-submit

    Added Option Groups to fpvian_basher_freestyle Preset

commit d19f7be
Author: FPVian <96704941+FPVian@users.noreply.github.com>
Date:   Wed Jan 19 20:29:09 2022 -0500

    Added Option Groups to fpvian_basher_freestyle Preset

    fixed missing #

    testing in configurator

commit 730638d
Merge: d74329c e05fcfc
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Wed Jan 19 16:11:44 2022 -0600

    Merge pull request betaflight#166 from FPVian/fpvian-submit

    Added fpvian_basher_freestyle preset

commit e05fcfc
Author: FPVian <96704941+FPVian@users.noreply.github.com>
Date:   Sun Jan 16 15:39:14 2022 -0500

    Added fpvian_basher_freestyle preset

    Made suggested changes from PR

commit e2f39f0
Author: NemesisXB <nemesisxb@users.noreply.github.com>
Date:   Tue Jan 18 10:19:50 2022 +0200

    Update Speedybee TX800 with OPTION_GROUP for Regulatory Domain

commit 790cff6
Author: NemesisXB <nemesisxb@users.noreply.github.com>
Date:   Tue Jan 18 10:10:39 2022 +0200

    Update diatone maba ultra 1000 with option_group

commit d74329c
Merge: cb98a57 18fd20e
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Mon Jan 17 17:41:22 2022 -0600

    Merge pull request betaflight#163 from limonspb/option_group

    Cleaning index from unused properties, adding preset priority, options groups

commit cb98a57
Merge: 936ea51 156752e
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sun Jan 16 02:37:11 2022 -0600

    Merge pull request betaflight#164 from sfjuocekr/nanohawk

    Add NanoHawk vtx table preset SmartAudio 2.0

commit 156752e
Author: sfjuocekr <sfjuocekr@gmail.com>
Date:   Sat Jan 15 15:37:57 2022 +0100

    add nanohawk preset

commit 18fd20e
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Fri Jan 14 03:36:21 2022 -0600

    Cleaning index from unused properties, adding preset priority, adding option grups

commit 936ea51
Merge: f6e070e e8590e5
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Fri Jan 14 01:16:21 2022 -0600

    Merge pull request betaflight#162 from limonspb/rc_link_defaults_description_fix

    RC_LINK defaults: remove rx protocol from description

commit e8590e5
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Fri Jan 14 00:54:03 2022 -0600

    RC_LINK defaults: remove rx protocol from description

commit f6e070e
Merge: 7d076c9 1d600c4
Author: ctzsnooze <chris@th.id.au>
Date:   Fri Jan 14 12:42:11 2022 +1100

    Merge pull request betaflight#160 from limonspb/rc_link_defaults

    RC_LINK fixes: defaults.txt and typos

commit 1d600c4
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Tue Jan 11 20:54:10 2022 -0600

    RC_LINK fixes: defaults.txt and typos

commit 7d076c9
Merge: 11160de c6d4d23
Author: Jan Post <post@stud.tu-darmstadt.de>
Date:   Tue Jan 11 13:44:49 2022 +0100

    Merge pull request betaflight#159 from sugaarK/GHST

    changed hz to Hz

commit c6d4d23
Author: sugaarK <83344205+sugaarK@users.noreply.github.com>
Date:   Tue Jan 11 22:38:47 2022 +1100

    changed hz to Hz

    grammer corrections

commit 11160de
Merge: dc15749 73cd314
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Tue Jan 11 04:52:05 2022 -0600

    Merge pull request betaflight#157 from JyeSmith/adds-openvtx-preset

    adds openvtx preset

commit dc15749
Merge: 1c9d5d6 f84cad1
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Tue Jan 11 01:37:08 2022 -0600

    Merge pull request betaflight#156 from sugaarK/GHST

    IRC Ghost preset

commit f84cad1
Author: sugaarK <83344205+sugaarK@users.noreply.github.com>
Date:   Mon Jan 10 22:27:29 2022 +1100

    IRC Ghost preset

    presets in race, freestyle and longrange version.. and yes i have exculded mode that make no sense for the use

    EXPERIMENTAL STATUS

    Grammer fixes

    ImmersionRC

    more shitty grammerrrreeerrrr

commit 73cd314
Author: Jye <JyeSmith@users.noreply.github.com>
Date:   Tue Jan 11 09:58:14 2022 +1000

    adds openvtx preset

commit 1c9d5d6
Merge: 8929451 cd063d9
Author: sugaarK <skunkworksbikes@gmail.com>
Date:   Mon Jan 10 16:24:24 2022 +1100

    Merge pull request betaflight#154 from sugaarK/karate-update-

    added race link options to karate race tune

commit 8929451
Merge: 8eddd19 54b0c1c
Author: sugaarK <skunkworksbikes@gmail.com>
Date:   Mon Jan 10 16:23:51 2022 +1100

    Merge pull request betaflight#153 from sugaarK/tbs-link-fixes

    replaced tbs rc link presets with race, freestyle and  longrange

commit 8eddd19
Merge: f683e0e 9d41d7b
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sun Jan 9 22:06:47 2022 -0600

    Merge pull request betaflight#148 from ctzsnooze/Redpine

    redpine experimental RC_LINK preset

commit 54b0c1c
Author: sugaarK <83344205+sugaarK@users.noreply.github.com>
Date:   Sun Jan 9 23:58:04 2022 +1100

    tidy up

    replaced tbs rc link presets with race, freestyle and  longrange

    removed extra discussion  lines

    Incorrect pr number

commit cd063d9
Author: sugaarK <83344205+sugaarK@users.noreply.github.com>
Date:   Mon Jan 10 00:18:38 2022 +1100

    added race link options to karate race tune

    added tracer elrs and ghost options to the karate race tune

    fixed option

commit f683e0e
Merge: cb315a8 f816594
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sun Jan 9 06:32:15 2022 -0600

    Merge pull request betaflight#150 from ctzsnooze/add-rc-link-speed-options-to-ctzsnooze-4s-tune

    add rc link option to ctzsnooze 4S race tune

commit cb315a8
Merge: 24b5dec 2a93d82
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sun Jan 9 06:31:53 2022 -0600

    Merge pull request betaflight#152 from ctzsnooze/updates-to-whoop-tune-by-Justice

    updates and fixes to Whoop tune from Justice

commit 24b5dec
Merge: 27b81c1 7aea6e2
Author: ctzsnooze <chris@th.id.au>
Date:   Sun Jan 9 23:10:28 2022 +1100

    Merge pull request betaflight#151 from betaflight/limonspb-patch-freedom_spec

    FreedomSpec Tune: remove dshot_idle_value

commit 2a93d82
Author: ctzsnooze <chris.thompson@sydney.edu.au>
Date:   Sun Jan 9 22:51:46 2022 +1100

    updates and fixes to Whoop tune from Justice

commit 7aea6e2
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sun Jan 9 03:24:01 2022 -0600

    FreedomSpec Tune: remove dshot_idle_value

    dshot_idle_value does not matter in this preset because dynamic idle is being used anyways

commit f816594
Author: ctzsnooze <chris.thompson@sydney.edu.au>
Date:   Sun Jan 9 12:55:26 2022 +1100

    add rc link option to ctzsnooze 4S race tune

commit 27b81c1
Merge: c2dc103 a0b5016
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sat Jan 8 17:15:32 2022 -0600

    Merge pull request betaflight#149 from ctzsnooze/Add-Normal-Tune-option-for-Justices-Whoop-PR

    add normal tune to Justice's Whoop PR

commit a0b5016
Author: ctzsnooze <chris.thompson@sydney.edu.au>
Date:   Sun Jan 9 10:07:10 2022 +1100

    add normal tune

commit 9d41d7b
Author: ctzsnooze <chris.thompson@sydney.edu.au>
Date:   Sun Jan 9 09:43:15 2022 +1100

    redpine

commit c2dc103
Merge: aa0feca 53a0f91
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sat Jan 8 16:40:01 2022 -0600

    Merge pull request betaflight#143 from ctzsnooze/filter-preset-updates

    update for cinematic settings and minor link changes

commit aa0feca
Merge: 159c40d 6ac9e0e
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Sat Jan 8 16:35:06 2022 -0600

    Merge pull request betaflight#142 from ctzsnooze/whoop-preset-by-justice

    whoop tune by Justice (Gary Kent)

commit 6ac9e0e
Author: ctzsnooze <chris.thompson@sydney.edu.au>
Date:   Sat Jan 8 14:36:49 2022 +1100

    whoop tune by Justice (Gary Kent)

commit 53a0f91
Author: ctzsnooze <chris.thompson@sydney.edu.au>
Date:   Sat Jan 8 12:34:28 2022 +1100

    update for cinematic settings and minor link changes

    typo fix

commit 159c40d
Merge: 77375f3 5fdbae1
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Wed Jan 5 12:15:09 2022 -0600

    Merge pull request betaflight#141 from DusKing1/add-bmi270-filter-settings

    Add bmi270 filter settings

commit 5fdbae1
Author: DusKing1 <1483569698@qq.com>
Date:   Mon Oct 11 20:13:56 2021 +0800

    add filter presets for BMI270 gyro

commit 77375f3
Merge: a1dc501 e90b146
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Wed Jan 5 00:53:45 2022 -0600

    Merge pull request betaflight#140 from limonspb/uniquevalues_sorting_fix

    Sort unique search strings alphabetically but case-insensitive (for keywords, authors etc)

commit e90b146
Author: Ivan Efimov <gendalf44@yandex.ru>
Date:   Tue Jan 4 21:36:28 2022 -0600

    Sort unique search string alphabetically but case-insensitive
@babang1da
Copy link

babang1da commented Jul 14, 2022 •
edited
Loading

set gyro_hardware_lpf = OPTION_2 does not work
Allowed values: NORMAL, EXPERIMENTAL

@sugaarK
Copy link
Member

sugaarK commented Jul 14, 2022

set gyro_hardware_lpf = OPTION_2 does not work
Allowed values: NORMAL, EXPERIMENTAL

you must be using an older 4.3 build one of the rc builds perhaps... the new modes are defiantly in the 4.3 release

@rochford77
Copy link
Contributor

please dont take this the wrong way, but this preset along with #182 should now be marked as 4.2 or removed IMO.

THis preset was SUPER helpful before we had with osr4/"normal"mode, but now with the lower internal cutoff there are no longer special considerations to take with the bmi 270 compared with other popular gyros like the MPU-6000. This preset simply existing as a 4.3 preset just adds confusion to people flashing. I see people ask at least once a day if they need this preset on various socials, and those who flash without asking end up severely over-filtered, with a worse flying quad.

This still provides value as a 4.2 preset.

@rochford77 rochford77 mentioned this pull request Aug 29, 2022
Closed
@sugaarK
Copy link
Member

sugaarK commented Nov 23, 2022

removing these due to constant complaints about them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@limonspb limonspb limonspb left review comments

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DusKing1 @limonspb @babang1da @sugaarK @rochford77 @ctzsnooze @KarateBrot