Merge pull request #3805 from betagouv/test-fix

Fix du test concernant l'API Brevo
betagouv · Apr 18, 2024 · 8a47dd7 · 8a47dd7
2 parents 7490ce0 + b762b8b
commit 8a47dd7
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/macantine/tests/test_brevo_user_data.py b/macantine/tests/test_brevo_user_data.py
@@ -2,15 +2,16 @@
 
 # import sib_api_v3_sdk
 from django.test import TestCase
-from django.test.utils import tag
 from macantine import tasks
 from freezegun import freeze_time
 from data.factories import UserFactory, CanteenFactory, DiagnosticFactory, TeledeclarationFactory
 from data.models import Teledeclaration, Canteen, Diagnostic
 
 
 class TestBrevoUserData(TestCase):
-    @tag("DEBUG")
+    def _find_payload_for_user(contacts, user_email):
+        return next(filter(lambda x: x.email == user_email, contacts))
+
     @freeze_time("2021-01-20")
     @mock.patch("macantine.tasks.contacts_api_instance.create_contact")
     @mock.patch("macantine.tasks.contacts_api_instance.update_batch_contacts")
@@ -25,7 +26,7 @@ def test_batch_user_updates(self, batch_update_mock, create_contact_mock):
         batch_update_mock.assert_called_once()
         create_contact_mock.assert_not_called()
 
-        payload = batch_update_mock.call_args[0][0].contacts[0]
+        payload = TestBrevoUserData._find_payload_for_user(batch_update_mock.call_args[0][0].contacts, new_user.email)
         self.assertEqual(payload.email, new_user.email)
 
         attributes = payload.attributes
@@ -72,7 +73,7 @@ def test_user_has_empty_canteen(self, batch_update_mock, create_contact_mock):
         batch_update_mock.assert_called_once()
         create_contact_mock.assert_not_called()
 
-        payload = batch_update_mock.call_args[0][0].contacts[0]
+        payload = TestBrevoUserData._find_payload_for_user(batch_update_mock.call_args[0][0].contacts, user.email)
         attributes = payload.attributes
         self.assertEqual(attributes.get("MA_CANTINE_GERE_UN_ETABLISSEMENT"), True)
         self.assertEqual(attributes.get("MA_CANTINE_MANQUE_BILAN_DONNEES_2023"), True)
@@ -94,7 +95,7 @@ def test_user_has_published_canteen(self, batch_update_mock, create_contact_mock
         batch_update_mock.assert_called_once()
         create_contact_mock.assert_not_called()
 
-        payload = batch_update_mock.call_args[0][0].contacts[0]
+        payload = TestBrevoUserData._find_payload_for_user(batch_update_mock.call_args[0][0].contacts, user.email)
         attributes = payload.attributes
         self.assertEqual(attributes.get("MA_CANTINE_GERE_UN_ETABLISSEMENT"), True)
         self.assertEqual(attributes.get("MA_CANTINE_MANQUE_BILAN_DONNEES_2023"), True)
@@ -119,7 +120,7 @@ def test_user_has_canteen_with_diag(self, batch_update_mock, create_contact_mock
         batch_update_mock.assert_called_once()
         create_contact_mock.assert_not_called()
 
-        payload = batch_update_mock.call_args[0][0].contacts[0]
+        payload = TestBrevoUserData._find_payload_for_user(batch_update_mock.call_args[0][0].contacts, user.email)
         attributes = payload.attributes
         self.assertEqual(attributes.get("MA_CANTINE_GERE_UN_ETABLISSEMENT"), True)
         self.assertEqual(attributes.get("MA_CANTINE_MANQUE_BILAN_DONNEES_2023"), True)
@@ -159,7 +160,7 @@ def test_user_has_canteen_with_td(self, batch_update_mock, create_contact_mock):
         batch_update_mock.assert_called_once()
         create_contact_mock.assert_not_called()
 
-        payload = batch_update_mock.call_args[0][0].contacts[0]
+        payload = TestBrevoUserData._find_payload_for_user(batch_update_mock.call_args[0][0].contacts, user.email)
         attributes = payload.attributes
         self.assertEqual(attributes.get("MA_CANTINE_GERE_UN_ETABLISSEMENT"), True)
         self.assertEqual(attributes.get("MA_CANTINE_MANQUE_BILAN_DONNEES_2023"), True)
@@ -195,7 +196,7 @@ def test_user_has_sat_canteen_with_cc_diag(self, batch_update_mock, create_conta
         batch_update_mock.assert_called_once()
         create_contact_mock.assert_not_called()
 
-        payload = batch_update_mock.call_args[0][0].contacts[0]
+        payload = TestBrevoUserData._find_payload_for_user(batch_update_mock.call_args[0][0].contacts, user.email)
         attributes = payload.attributes
         self.assertEqual(attributes.get("MA_CANTINE_GERE_UN_ETABLISSEMENT"), True)
         self.assertEqual(attributes.get("MA_CANTINE_MANQUE_BILAN_DONNEES_2023"), True)
@@ -246,7 +247,7 @@ def test_user_has_sat_canteen_with_cc_td(self, batch_update_mock, create_contact
         batch_update_mock.assert_called_once()
         create_contact_mock.assert_not_called()
 
-        payload = batch_update_mock.call_args[0][0].contacts[0]
+        payload = TestBrevoUserData._find_payload_for_user(batch_update_mock.call_args[0][0].contacts, user.email)
         attributes = payload.attributes
         self.assertEqual(attributes.get("MA_CANTINE_GERE_UN_ETABLISSEMENT"), True)
         self.assertEqual(attributes.get("MA_CANTINE_MANQUE_BILAN_DONNEES_2023"), True)