Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FromAssistance should be FromAssistant #143

Closed
Swimburger opened this issue Mar 6, 2023 · 1 comment
Closed

FromAssistance should be FromAssistant #143

Swimburger opened this issue Mar 6, 2023 · 1 comment

Comments

@Swimburger
Copy link
Contributor

These helper methods are great, but the name of FromAssistance doesn't fully make sense.
It should be FromAssistant IMO.

openai/OpenAI.SDK/ObjectModels/RequestModels/ChatMessage.cs

Line 29 in f390f90

public static ChatMessage FromAssistance(string content)

Thanks for the library!
@kayhantolga
Copy link
Member

Thanks for reporting!

@Swimburger Swimburger mentioned this issue Mar 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename FromAssistance to FromAssistant
2 participants
@kayhantolga @Swimburger