Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefers-color-scheme for code-server icon #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krassowski
Copy link
Contributor

Follow-up to #61

Based on feedback after the PR was merged I arrived at a conclusion that JupyterLab should just set the preferred-color (jupyterlab/jupyterlab#16299).

@benz0li
Copy link

benz0li commented May 7, 2024

As mentioned in #60 (comment), this does not (yet) work with Safari.

@xhochy
Copy link
Collaborator

xhochy commented May 8, 2024

Would this PR still improve on the status quo, though?

@krassowski
Copy link
Contributor Author

I think yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants