Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to switch the icon to code-server icon #60

Closed
krassowski opened this issue Apr 18, 2024 · 2 comments · Fixed by #61
Closed

Allow to switch the icon to code-server icon #60

krassowski opened this issue Apr 18, 2024 · 2 comments · Fixed by #61

Comments

@krassowski
Copy link
Contributor

Currently the VS Code icon is used even when code-server is run. This is problematic because the Visual Studio Code icon is a Microsoft trademark and should not be used to represent products other than VS Code as per https://code.visualstudio.com/brand

Proposed solution:

Any thoughts/counter ideas before I open a PR?

@benz0li
Copy link

benz0li commented Apr 22, 2024

@krassowski
Copy link
Contributor Author

Good point on dark/light. prefers-color-scheme does not reflect the Jupyter theme (the browser/system may be set to dark but user may be using light theme). Instead we can add jp-icon0 class which will automatically swap the fill between black and white depending on theme

https://jupyterlab.readthedocs.io/en/latest/api/modules/ui_components.html#md:sync-icon-color-to-jupyterlab-theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants