-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to switch the icon to code-server icon #60
Comments
Because of https://bugs.webkit.org/show_bug.cgi?id=199134, this does not (yet) work with Safari, though. Therefore, I created https://github.com/b-data/jupyterlab-python-docker-stack/blob/42b36973157f29ec867a9489aa9c20e387873f60/base/assets/opt/code-server/code-server.svg |
Good point on dark/light. |
Currently the VS Code icon is used even when code-server is run. This is problematic because the Visual Studio Code icon is a Microsoft trademark and should not be used to represent products other than VS Code as per https://code.visualstudio.com/brand
Proposed solution:
Any thoughts/counter ideas before I open a PR?
The text was updated successfully, but these errors were encountered: