Python code cleanup across docs, wrappers, testing (#2194) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR incorporates suggested changes from issue rapidsai#2037, opened back in 22.02, as well as cleaning up documentation and testing code from 22.04 work. Specifically, this PR does the following: - Removes worker helpers from MNMG algos in the online documentation (e.g. `call_katz_centrality`, `call_louvain`, `call_wcc`) - Adds helpers from comms such as `get_comms`, `get_session_id`, `get_2D_partition`, is_initialized that were previously missing - Adds helpers from NumberMap such as `from_internal_vertex_id`, `to_internal_vertex_id`, `renumber`, `set_renumbered_col_names` - Add MNMG Hits and Node2vec to docs - Added docstring descriptions and examples to methods that were missing them - Fixed docstring examples in `egonet.py`, `node2vec.py` - Adds `pylibcugraph` docstring examples to the list of examples tested in `cugraph/tests/test_doctests.py` - Adds support for MG Dask docstring example testing, tested in newly created `cugraph/tests/dask/test_mg_doctests.py` This PR addresses the items from and closes rapidsai#2227. This PR also closes rapidsai#2193. Authors: - https://github.com/betochimas Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai#2194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates suggested changes from issue rapidsai#2037, opened back in 22.02, as well as cleaning up documentation and testing code from 22.04 work.
Specifically, this PR does the following:
call_katz_centrality,call_louvain,call_wcc)get_comms,get_session_id,get_2D_partition, is_initialized that were previously missingfrom_internal_vertex_id,to_internal_vertex_id,renumber,set_renumbered_col_namesegonet.py,node2vec.pypylibcugraphdocstring examples to the list of examples tested incugraph/tests/test_doctests.pycugraph/tests/dask/test_mg_doctests.pyThis PR addresses the items from and closes rapidsai#2227.
This PR also closes rapidsai#2193.
Authors:
Approvers:
URL: rapidsai#2194