Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python code cleanup across docs, wrappers, testing #2194

Merged
merged 12 commits into from
Apr 30, 2022

Conversation

betochimas
Copy link
Contributor

@betochimas betochimas commented Apr 6, 2022

This PR incorporates suggested changes from issue #2037, opened back in 22.02, as well as cleaning up documentation and testing code from 22.04 work.

Specifically, this PR does the following:

  • Removes worker helpers from MNMG algos in the online documentation (e.g. call_katz_centrality, call_louvain, call_wcc)
  • Adds helpers from comms such as get_comms, get_session_id, get_2D_partition, is_initialized that were previously missing
  • Adds helpers from NumberMap such as from_internal_vertex_id, to_internal_vertex_id, renumber, set_renumbered_col_names
  • Add MNMG Hits and Node2vec to docs
  • Added docstring descriptions and examples to methods that were missing them
  • Fixed docstring examples in egonet.py, node2vec.py
  • Adds pylibcugraph docstring examples to the list of examples tested in cugraph/tests/test_doctests.py
  • Adds support for MG Dask docstring example testing, tested in newly created cugraph/tests/dask/test_mg_doctests.py

This PR addresses the items from and closes #2227.
This PR also closes #2193.

@betochimas betochimas added doc Documentation non-breaking Non-breaking change labels Apr 6, 2022
@betochimas betochimas added this to the 22.06 milestone Apr 6, 2022
Define C API for eigenvector centrality (rapidsai#2180)
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #2194 (220eaf5) into branch-22.06 (728950e) will decrease coverage by 0.10%.
The diff coverage is 21.59%.

❗ Current head 220eaf5 differs from pull request most recent head 9eba1c0. Consider uploading reports for the commit 9eba1c0 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06    #2194      +/-   ##
================================================
- Coverage         71.33%   71.22%   -0.11%     
================================================
  Files               171      172       +1     
  Lines             11207    11277      +70     
================================================
+ Hits               7994     8032      +38     
- Misses             3213     3245      +32     
Impacted Files Coverage Δ
...graph/cugraph/centrality/betweenness_centrality.py 89.65% <ø> (ø)
python/cugraph/cugraph/comms/comms.py 70.23% <ø> (+35.71%) ⬆️
python/cugraph/cugraph/community/egonet.py 97.36% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 85.29% <ø> (ø)
...cugraph/cugraph/dask/centrality/katz_centrality.py 25.00% <ø> (ø)
python/cugraph/cugraph/dask/common/read_utils.py 86.66% <ø> (ø)
python/cugraph/cugraph/dask/community/louvain.py 25.80% <ø> (-0.67%) ⬇️
...on/cugraph/cugraph/dask/components/connectivity.py 25.92% <ø> (ø)
python/cugraph/cugraph/dask/link_analysis/hits.py 18.36% <ø> (ø)
...hon/cugraph/cugraph/dask/link_analysis/pagerank.py 17.77% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 728950e...9eba1c0. Read the comment docs.

@betochimas betochimas marked this pull request as ready for review April 7, 2022 19:19
@betochimas betochimas requested review from a team as code owners April 7, 2022 19:19
@betochimas betochimas added Epic Tracker for a relatively large body of work that is broken down into stories and issues 3 - Ready for Review and removed Epic Tracker for a relatively large body of work that is broken down into stories and issues labels Apr 14, 2022
@betochimas
Copy link
Contributor Author

rerun tests

@betochimas
Copy link
Contributor Author

rerun tests

1 similar comment
@betochimas
Copy link
Contributor Author

rerun tests

@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 34a40a7 into rapidsai:branch-22.06 Apr 30, 2022
betochimas added a commit to betochimas/cugraph that referenced this pull request May 2, 2022
Python code cleanup across docs, wrappers, testing (rapidsai#2194)
betochimas added a commit to betochimas/cugraph that referenced this pull request May 2, 2022
Python code cleanup across docs, wrappers, testing (rapidsai#2194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
4 participants